fix: Input inline allowClear style #23259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8537e6e:
|
|
还是有这个问题 #22574 (comment) |
|
唔，placeholder 的确是没什么好办法。 |
|
嗯，我也没想到，确实有点棘手 |
|
那只能搞个假的 |
Codecov Report
@@ Coverage Diff @@
## master #23259 +/- ##
==========================================
- Coverage 98.35% 98.35% -0.01%
==========================================
Files 364 364
Lines 7284 7279 -5
Branches 1951 1993 +42
==========================================
- Hits 7164 7159 -5
Misses 120 120
Continue to review full report at Codecov.
|
|
input 搞假 placeholder 没必要啊。 |
shaodahong
approved these changes
Apr 14, 2020
|
假的 placeholder 也有一些兼容性问题，太拼了 |
|
👌 那先这样吧，有 issue 再来搞。 |
xrkffgg
pushed a commit
that referenced
this pull request
Apr 16, 2020
* fix: Input allow clear icon * update test case * update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
fix #22562
💡 Background and solution
📝 Changelog
allowClearshaking when trigger clear icon.allowClear内联展示时，触发清除按钮样式抖动的问题。☑️ Self Check before Merge