Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove DatePicker legacy cell className #21589

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 25, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 🚮 Remove DatePicker legacy cell className for custom cell style.
🇨🇳 Chinese 🚮 移除 DatePicker 针对自定义单元格的 3.x 的兼容类名。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: draft label Feb 25, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 25, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 25, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6e48c91:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #21589 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21589   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files         304      304           
  Lines        7015     7015           
  Branches     1933     1898   -35     
=======================================
  Hits         6865     6865           
  Misses        150      150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc8bc19...6e48c91. Read the comment docs.

@afc163

This comment has been minimized.

@afc163

This comment has been minimized.

@afc163 afc163 changed the title refactor: Reduce DatePicker css bundle size refactor: Remove DatePicker legacy cell className Feb 25, 2020
@afc163
Copy link
Member Author

afc163 commented Feb 25, 2020

Gziped 后下降 0.18kb

- 61.15KB
+ 60.97KB

@afc163 afc163 marked this pull request as ready for review February 25, 2020 11:40
@zombieJ zombieJ merged commit 50087b2 into master Feb 25, 2020
@zombieJ zombieJ deleted the ruduce-css-size branch February 25, 2020 11:41
@pr-triage pr-triage bot added PR: merged and removed PR: draft labels Feb 25, 2020
@zombieJ zombieJ mentioned this pull request Feb 27, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants