Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dark css dist error caused by variables #20336

Merged

Conversation

PeachScript
Copy link
Member

@PeachScript PeachScript commented Dec 18, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

None

💡 Background and solution

After #20117 , antd.dark.css stil contains a part of default styles that will make UI broken, so extract dark entry to a single webpack config and compile dark theme via the official documentation way.

📝 Changelog

Language Changelog
🇺🇸 English --
🇨🇳 Chinese --

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Dec 18, 2019

Deploy preview for ant-design ready!

Built with commit 9fc3afe

https://deploy-preview-20336--ant-design.netlify.com

@ycjcl868 ycjcl868 added the 4.x In Ant Design 4.0 label Dec 18, 2019
@ycjcl868 ycjcl868 merged commit ae69b13 into ant-design:feat-dark-palette Dec 18, 2019
@pr-triage pr-triage bot added the PR: merged label Dec 18, 2019
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9fc3afe:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #20336 into feat-dark-palette will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           feat-dark-palette   #20336   +/-   ##
==================================================
  Coverage              97.55%   97.55%           
==================================================
  Files                    294      294           
  Lines                   6839     6839           
  Branches                1879     1878    -1     
==================================================
  Hits                    6672     6672           
  Misses                   167      167

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4760877...9fc3afe. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x In Ant Design 4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants