Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove accounts, use account & rename chains and wallets #137

Merged
merged 3 commits into from
Nov 29, 2023
Merged

refactor: remove accounts, use account & rename chains and wallets #137

merged 3 commits into from
Nov 29, 2023

Conversation

yutingzhao1991
Copy link
Collaborator

  • 去掉 accounts，改为 account，通过 account 来判断是否已连接，去掉 connected。未来有多账户的情况再支持 accounts。
  • 重命名 chains 和 wallets，改为 availableChains 和 availableWallets，语义更明确，另外为未来可能支持同时连接多个链或者多个钱包预留命名空间。

@yutingzhao1991 yutingzhao1991 requested review from kiner-tang and jeasonstudio and removed request for kiner-tang November 29, 2023 01:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2023 •
edited
Loading

@yutingzhao1991 yutingzhao1991 merged commit a81b4c9 into main Nov 29, 2023
3 checks passed
@yutingzhao1991 yutingzhao1991 deleted the refactor/accounts branch November 29, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiner-tang kiner-tang kiner-tang approved these changes

@jeasonstudio jeasonstudio Awaiting requested review from jeasonstudio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yutingzhao1991 @kiner-tang