Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ConfigProvider): add icons config #6587

Merged
merged 42 commits into from
Jun 12, 2024
Merged

feat(ConfigProvider): add icons config #6587

merged 42 commits into from
Jun 12, 2024

Conversation

guoyunhe
Copy link
Contributor

@guoyunhe guoyunhe commented Apr 3, 2024

增加一种通过 <ConfigProvider> 设置全局图标替换的方式:

import { SuccessFill, ErrorFill, Loading } from 'my-icon-pack'

<ConfigProvider icons={{
  ToastSuccess: SuccessFill,
  ToastFail: ErrorFill,
  ToastLoading: Loading,
}}>
  <App/>
</ConfigProvider>

Copy link
Contributor

github-actions bot commented Apr 3, 2024

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6587.surge.sh

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (cf550e4) to head (a10882d).
Report is 15 commits behind head on master.

Current head a10882d differs from pull request most recent head cefc14a

Please upload reports for the commit cefc14a to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6587      +/-   ##
==========================================
+ Coverage   92.34%   92.52%   +0.17%     
==========================================
  Files         318      319       +1     
  Lines        6910     6969      +59     
  Branches     1729     1760      +31     
==========================================
+ Hits         6381     6448      +67     
+ Misses        493      485       -8     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
./lib/bundle/antd-mobile.es.js 102.44 KB (+452 B 🔺) 2.1 s (+0.44% 🔺) 846 ms (-1.75% 🔽) 2.9 s

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Size Change: +1.45 kB (+0.41%)

Total Size: 355 kB

Filename Size Change
./lib/bundle/antd-mobile.compatible.umd.js 191 kB +957 B (+0.5%)
./lib/bundle/antd-mobile.umd.js 145 kB +500 B (+0.35%)
./lib/bundle/style.css 18 kB -3 B (-0.02%)
ℹ️ View Unchanged
Filename Size
./lib/bundle/css-vars-patch.css 1.42 kB

compressed-size-action

@guoyunhe guoyunhe force-pushed the config-provider-icons branch 4 times, most recently from 0e24aca to a10882d Compare April 4, 2024 06:01
@guoyunhe guoyunhe requested a review from zombieJ April 4, 2024 06:34
@guoyunhe guoyunhe force-pushed the config-provider-icons branch 8 times, most recently from 2e3a0c1 to ab0d47b Compare April 8, 2024 12:38
@guoyunhe guoyunhe force-pushed the config-provider-icons branch 3 times, most recently from 219bde4 to 9f3cd52 Compare April 11, 2024 08:19
@zombieJ zombieJ merged commit 2203ba2 into master Jun 12, 2024
8 checks passed
@zombieJ zombieJ deleted the config-provider-icons branch June 12, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants