Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: cascader): wrong placement and selected node order #4265

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #4261

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Oct 12, 2024

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 42.25%. Comparing base (aea640c) to head (cd1287c).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
components/cascader/Cascader.razor.cs 9.09% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4265      +/-   ##
==========================================
+ Coverage   42.22%   42.25%   +0.03%     
==========================================
  Files         590      592       +2     
  Lines       31082    31094      +12     
  Branches     6010     6012       +2     
==========================================
+ Hits        13123    13138      +15     
- Misses      16850    16854       +4     
+ Partials     1109     1102       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit 4a2f4d7 into master Oct 13, 2024
5 of 6 checks passed
@ElderJames ElderJames deleted the fix/cascader-placement branch October 13, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cascader will select the first found node if there are multiple same value
1 participant