Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: form): exception during validation for some nullable types #4137

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #4134

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Aug 27, 2024

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 43.24%. Comparing base (4ad8e7c) to head (230dca0).
Report is 2 commits behind head on master.

Files Patch % Lines
...Validate/ValidationAttribute/NumberMaxAttribute.cs 0.00% 1 Missing and 1 partial ⚠️
...Validate/ValidationAttribute/NumberMinAttribute.cs 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4137       +/-   ##
===========================================
+ Coverage    1.41%   43.24%   +41.83%     
===========================================
  Files         583      583               
  Lines       29703    29771       +68     
  Branches     5868     5894       +26     
===========================================
+ Hits          419    12874    +12455     
+ Misses      29244    15823    -13421     
- Partials       40     1074     +1034     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit eb5b19a into master Aug 27, 2024
5 of 6 checks passed
@ElderJames ElderJames deleted the fix/form-nullable-types-validation branch August 27, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormValidationRule does not work with nullable types
1 participant