Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: form): support interactive localization for DataAnnotations #3823

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Apr 25, 2024

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 43.49%. Comparing base (5a22bb8) to head (ac6e0b0).
Report is 1 commits behind head on master.

Files Patch % Lines
components/core/Reflection/PropertyReflector.cs 0.00% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3823       +/-   ##
===========================================
+ Coverage    1.49%   43.49%   +41.99%     
===========================================
  Files         577      580        +3     
  Lines       27928    28222      +294     
  Branches     5667     5737       +70     
===========================================
+ Hits          417    12274    +11857     
+ Misses      27471    14931    -12540     
- Partials       40     1017      +977     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit 5c33864 into master Apr 25, 2024
6 checks passed
@ElderJames ElderJames deleted the feat/form-localization branch April 25, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant