Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: select): DropdownRender doesn't pass original content into renderfargment #3675

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fixed Select that the DropdownRender doesn't pass original content into renderfargment
🇨🇳 Chinese 修复 Select 的 DropdownRender 属性没有传入原内容

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Feb 7, 2024

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (ae67bcb) 1.51% compared to head (766d379) 1.50%.

Files Patch % Lines
components/select/Select.razor 0.00% 81 Missing ⚠️
components/select/Select.razor.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3675      +/-   ##
=========================================
- Coverage    1.51%   1.50%   -0.01%     
=========================================
  Files         572     572              
  Lines       27587   27688     +101     
  Branches     5600    5595       -5     
=========================================
  Hits          417     417              
- Misses      27130   27231     +101     
  Partials       40      40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit 1b8a9c3 into master Feb 8, 2024
4 of 6 checks passed
@ElderJames ElderJames deleted the fix/select-dropdwn-render branch February 8, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant