-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module: notification): RTL incorrect style #3049
fix(module: notification): RTL incorrect style #3049
Conversation
Thanks for contribution @zxyao145 , I found a little problem that after open the natification on top or bottom, I open other one with other placement again, the top or bottom natification would open again. |
Codecov ReportBase: 43.84% // Head: 43.84% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3049 +/- ##
==========================================
- Coverage 43.84% 43.84% -0.01%
==========================================
Files 556 556
Lines 26687 26692 +5
Branches 263 263
==========================================
+ Hits 11701 11703 +2
- Misses 14946 14949 +3
Partials 40 40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🤔 This is a ...
🔗 Related issue link
#3040
💡 Background and solution
📝 Changelog
2. feat(module: notification): add top and bottom placement support;
3. fix(module: modal): patch.less is lost when sync the css;
4. fix(module: AntDomComponentBase): ClassMapper.ToString() generates Class parameters twice
2. notification 新增 top 和 bottom 位置支持;
3. 修复 modal 同步样式时导致 patch.less 丢失;
4. 修复 AntDomComponentBase 中 ClassMapper.ToString() 时重复输出 Class 参数的问题
☑️ Self Check before Merge