Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: notification): RTL incorrect style #3049

Merged
merged 6 commits into from
Jan 31, 2023

Conversation

zxyao145
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#3040

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 1. fix(module: notification): RTL incorrect style;
2. feat(module: notification): add top and bottom placement support;
3. fix(module: modal): patch.less is lost when sync the css;
4. fix(module: AntDomComponentBase): ClassMapper.ToString() generates Class parameters twice
🇨🇳 Chinese 1. 修复 notification 在 RTL 下显示异常问题;
2. notification 新增 top 和 bottom 位置支持;
3. 修复 modal 同步样式时导致 patch.less 丢失;
4. 修复 AntDomComponentBase 中 ClassMapper.ToString() 时重复输出 Class 参数的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jan 29, 2023

@zxyao145 zxyao145 requested a review from ElderJames January 29, 2023 14:47
@ElderJames
Copy link
Member

Thanks for contribution @zxyao145 , I found a little problem that after open the natification on top or bottom, I open other one with other placement again, the top or bottom natification would open again.

natification-bug

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 43.84% // Head: 43.84% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (06108c1) compared to base (33cf431).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3049      +/-   ##
==========================================
- Coverage   43.84%   43.84%   -0.01%     
==========================================
  Files         556      556              
  Lines       26687    26692       +5     
  Branches      263      263              
==========================================
+ Hits        11701    11703       +2     
- Misses      14946    14949       +3     
  Partials       40       40              
Impacted Files Coverage Δ
components/core/Base/AntDomComponentBase.cs 95.83% <ø> (-0.33%) ⬇️
components/notification/Notification.razor 0.00% <0.00%> (ø)
components/notification/Notification.razor.cs 0.00% <0.00%> (ø)
components/notification/NotificationItem.razor 0.00% <0.00%> (ø)
components/core/Component/Overlay/Overlay.razor.cs 86.04% <0.00%> (-1.75%) ⬇️
components/drawer/Drawer.razor.cs 93.54% <0.00%> (+3.22%) ⬆️
components/core/Base/AntComponentBase.cs 57.14% <0.00%> (+3.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zxyao145
Copy link
Member Author

Thanks for contribution @zxyao145 , I found a little problem that after open the natification on top or bottom, I open other one with other placement again, the top or bottom natification would open again.

natification-bug natification-bug

fixed

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit 4f8eafa into ant-design-blazor:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification Component doesn't show Close button in Correct Position for Right To Left Languages
2 participants