Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module: reusetabs): remove ReuseTabsRouteView to reduce coupling to native components #3009

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jan 11, 2023

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 44.69% // Head: 43.19% // Decreases project coverage by -1.50% ⚠️

Coverage data is based on head (3a6e931) compared to base (27e6105).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #3009      +/-   ##
===========================================
- Coverage    44.69%   43.19%   -1.51%     
===========================================
  Files          556      556              
  Lines        26092    26176      +84     
  Branches       263      263              
===========================================
- Hits         11663    11307     -356     
- Misses       14389    14829     +440     
  Partials        40       40              
Impacted Files Coverage Δ
components/tabs/Reuse/ReuseTabs.razor 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabs.razor.cs 0.00% <0.00%> (ø)
components/list/ListItemLayout.cs 0.00% <0.00%> (-100.00%) ⬇️
components/list/ListItem.razor 0.00% <0.00%> (-95.31%) ⬇️
components/list/AntList.razor 0.00% <0.00%> (-92.31%) ⬇️
...omponents/form/Validate/Rule/FormRulesValidator.cs 0.00% <0.00%> (-76.93%) ⬇️
components/list/AntList.razor.cs 0.00% <0.00%> (-76.12%) ⬇️
components/list/ListItem.razor.cs 0.00% <0.00%> (-73.08%) ⬇️
components/form/Form.razor.cs 36.02% <0.00%> (-32.30%) ⬇️
components/form/FormItem.razor.cs 43.31% <0.00%> (-29.94%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit 978ffcb into feature Jan 13, 2023
@ElderJames ElderJames deleted the refactor/reusetabs-remove-routeview branch January 13, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant