fix(module: drawer): OffsetX and offsetY do not work (#1435) #1448

zxyao145 · 2021-05-01T13:07:56Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English	fix OffsetX and offsetY do not work of Drawer, and update the documents how to use DrawerService by the way.
🇨🇳 Chinese	修复 Drawer OffsetX 和offsetY 不起作用，并更新使用 DrawerService 的文档。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
Changelog is provided or not needed

github-actions · 2021-05-01T13:08:10Z

codecov-commenter · 2021-05-01T13:24:51Z

Codecov Report

Merging #1448 (6254acd) into master (8cbc57e) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #1448    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files         453     453            
  Lines       28529   28639   +110     
=======================================
- Misses      28529   28639   +110

Impacted Files	Coverage Δ
components/core/Base/AntDomComponentBase.cs	`0.00% <0.00%> (ø)`
components/drawer/Drawer.razor	`0.00% <0.00%> (ø)`
components/drawer/Drawer.razor.cs	`0.00% <0.00%> (ø)`
components/input/Input.cs	`0.00% <0.00%> (ø)`
components/input/TextArea.razor	`0.00% <0.00%> (ø)`
components/input/Search.razor.cs	`0.00% <0.00%> (ø)`
components/input/TextArea.razor.cs	`0.00% <0.00%> (ø)`
components/input/InputGroup.razor.cs	`0.00% <0.00%> (ø)`
components/input/InputPassword.razor.cs	`0.00% <0.00%> (ø)`
components/core/Base/AntComponentBase.cs	`0.00% <0.00%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cbc57e...6254acd. Read the comment docs.

anddrzejb · 2021-05-01T14:27:21Z

components/core/JsInterop/ObservableApi/resizeObserver.ts

@@ -1,8 +1,10 @@
 import { getDom } from '../interop';

+// @ts-ignore


May I ask what errors were you getting?

Error TS2304: Cannot find name 'ResizeObserver'.

Maybe because it's experimental? (In fact, all modern browsers support it except IE)

I don't think it is experimental any longer. I cannot find any reference to it being experimental... We do have a detection in place if it does not exist and a fallback to window.resize. On the other hand, I think IE will not be supported by AntBlazor anylonger.

To be honest I never got that error. But I guess there is no harm to have it here though 👍🏻 .

Yes, the word "experimental" does not exist in the English document of MDN. Maybe the Chinese document of MDN has not been updated.

anddrzejb · 2021-05-11T20:23:47Z

@zxyao145 There is a rendering problem with drawer. Please have a look at the gif. Notice that first time Left is clicked, the drawer seems to appear out of place. Second time is ok. The same applies to Right. If Left is clicked again after clicking on Right, whole flickering process repeats.

To be honest it looks awfully similar to a problem that I was dealing with DatePicker & Overlay in PR #1452. If you check the first comment, it is the point 2. I don't know if this is going to be helpful, but to be honest it does look like css class "leftover".

zxyao145 · 2021-05-12T01:39:42Z

@zxyao145 There is a rendering problem with drawer. Please have a look at the gif. Notice that first time Left is clicked, the drawer seems to appear out of place. Second time is ok. The same applies to Right. If Left is clicked again after clicking on Right, whole flickering process repeats.

To be honest it looks awfully similar to a problem that I was dealing with DatePicker & Overlay in PR #1452. If you check the first comment, it is the point 2. I don't know if this is going to be helpful, but to be honest it does look like css class "leftover".

Yes, that's the problem with demo. I'm repairing it locally

anddrzejb · 2021-05-14T06:11:24Z

@zxyao145 I think you need to update your branch for the build errors to go away.

ElderJames · 2021-05-14T10:13:21Z

@zxyao145 I found that the closing animation was lost.

zxyao145 · 2021-05-15T03:11:47Z

@zxyao145 I found that the closing animation was lost.

fixed

ElderJames · 2021-05-17T15:04:17Z

The drawer opening animation has a sense of paragraph, not smooth enough.

…or#1435)

…ppears

* test: DateHelperTests was in the wrong dir (#1529) * fix(module: radio): add defaultChecked and defaultValue (#1494) * fix(module: radio): add defaultChecked and defaultValue * add tests * add test for radio group * feat: Added locale es-ES (#1534) * fix(module: locale): add missing 'filterOptions' node to german locale file (#1562) * docs(module: table): update ‘fork official sample’ demo (#1544) Co-authored-by: James Yeung <[email protected]> * fix(module: npuNumber): include parser in value evaluation (#1567) * fix(module: input): fix & feat & docs & tests: Input general fixes (#1530) * docs(module:input): api correction & comments * fix(module:input): clear icon in sync with antD * fix(module:input): add parameter bordered * fix(module:textarea): add parameter ShowCounter * fix(module:input): Focus with behaviors * docs: add missing docs, rearrange order * fix(module:search): update to match new standard look doc(module:search): add API & demos * fix(module:inputgroup): override style to remove whitespace\ docs: same as react * fix(module:inputpassword): support custom icon docs: same as react * fix(module:input): add blur method docs: add blur method * fix(module:input): add readonly parameter * tests * fix * fix(module:input): sequence correction * Update components/core/Base/AntComponentBase.cs Co-authored-by: James Yeung <[email protected]> * review fixes * fix: clean-up * tests: fix missing mock * fix: focus * fix(module:input): bind clear button to _inputValue * tests: clear button show/hide * tests: package update Co-authored-by: James Yeung <[email protected]> * fix(module: drawer): OffsetX and offsetY do not work (#1435) (#1448) * fix(module: drawer): OffsetX and offsetY do not work (#1435) * docs: demo update * fix: Placement is switched to the relative direction, the animation appears * fix: the bug of closing animation missed * fix: incorrect animation * fix: different behaviors in WASM and Server side Co-authored-by: James Yeung <[email protected]> * docs: Added essential step in get started procedure (#1579) * Added essential step in get started procedure The article is missing the dependency registration. If these dependencies are not registered, the library couldn't be used (at least in my case). * Update getting-started.en-US.md Co-authored-by: James Yeung <[email protected]> * docs: document improvement (#1578) * fix the ordering of menu items * add ueditor link * fix icon document search style * fix affix width for side menu * add faq doc * feat(module: datepicker): Picker clear button event (#1586) * feat(module:datepicker): add OnClearClick eventcallback * docs(module:datepicker): format docs has same behavior as react docs * fix: adjust code to match net 3.1 * fix: eventcallback name fix * Update site/AntDesign.Docs/Demos/Components/DatePicker/doc/index.zh-CN.md Co-authored-by: James Yeung <[email protected]> * fix(module: dropdown): align with react (#1588) * fix(module:dropdownbutton): align with react version * doc(module:dropdownbutton): align with react docs * fix(module: table): fix can not close filter by confirm button (#1602) * fix(module: table): fix filter icon wrong highlight, fix filter behavior when there is no input value (#1592) * fix(module:table): fix filter icon wrong highlight * Update Column.razor * fix(module:table): fix filter for no input * fix(module: table): fix filter not applied (#1594) * fix(module: InputNumber): fix error when blur (#1612) * fix(affix): remove wrong event listeners (#1616) * fix(module: table): fix wrong compare operator, remove input components for unary filter operators (#1596) * fix(module:table): fix wrong compare operator * remove whitespace * fix(module:table): remove input component for 'is null' and 'is not null' table filter * Update Column.razor * fix(module:table): allow remove first filter * remove whitespace * Update Column.razor * Update Column.razor Co-authored-by: James Yeung <[email protected]> * fix(module: dropdown): dropdown button missing properties & docs fix for Dropdown & Button (#1609) * fix:fix(module:dropdownbutton): add regular button behaviors and properties * fix(module:button): add text type & docs * docs(module:dropdown): version correction * fix(module:overlay): re-add IsButton parameter * fix: add xml comment to public methods * fix(module:overlay): add xml documentation * fix(module:dropdown): chrome block button force * fix(module:button): remove Search parameter Co-authored-by: James Yeung <[email protected]> * fix(module: datepicker): in form behavior (#1617) * i18n: Add missing elements to Dutch locales (#1624) * chore(ci): fix coverage report uploading (#1614) * chore(ci): fix coverage report uploading * continue when fail to upload * docs: update modal and drawer docs (#1625) * docs: update modal docs * docs: modify DropdownInDrawer * docs: update demo for DrawerService and ModalService * fix(module: modal): Modal dialogs not showing anymore (#1635) * Fix issue #1634 - Modal dialogs not showing anymore * Removed unnecessary Search from ButtonProps as part of #1634 fix - Modal dialogs not showing anymore * fix(module: table): fix selection clear (#1632) * fix(module:table): fix selection issues * allow SetSeletion(null) when there is not a Selection column * allow change selection by setting RowDate.Selected * fix(module: checkbox): fix checkbox group in-form behavior (#1637) * fix(module: image): fix the style property position (#1642) * fix(module: tag): Issue solved & align with react antd & tests (#1631) * fix(module:tag): close does not trigger onclick add custom color handling add animation handling add status tags * docs(module:tag): align with react antd * tests(module:tag): add basic tests * fix: style fixes * fix: remove default animation; add custom animation demo * fix: remove ExtraCls and use Class from base * Update components/tag/Tag.razor * clear the open animate after tag opened * translate demo docs Co-authored-by: James Yeung <[email protected]> * changelog 0.8.2 (#1649) * add Visible back to Tag.razor.cs * Update SearchLoading.razor and idnex.en-US.md * Update index.zh-CN.md Co-authored-by: 笨木头 <[email protected]> Co-authored-by: James Yeung <[email protected]> Co-authored-by: Magehernan <[email protected]> Co-authored-by: Andrzej Bakun <[email protected]> Co-authored-by: zxyao <[email protected]> Co-authored-by: black-snake <[email protected]> Co-authored-by: Gregory Loones <[email protected]> Co-authored-by: Razvan Predescu <[email protected]>

* fix(module: drawer): OffsetX and offsetY do not work (#1435) * docs: demo update * fix: Placement is switched to the relative direction, the animation appears * fix: the bug of closing animation missed * fix: incorrect animation * fix: different behaviors in WASM and Server side Co-authored-by: James Yeung <[email protected]>

* test: DateHelperTests was in the wrong dir (#1529) * fix(module: radio): add defaultChecked and defaultValue (#1494) * fix(module: radio): add defaultChecked and defaultValue * add tests * add test for radio group * feat: Added locale es-ES (#1534) * fix(module: locale): add missing 'filterOptions' node to german locale file (#1562) * docs(module: table): update ‘fork official sample’ demo (#1544) Co-authored-by: James Yeung <[email protected]> * fix(module: npuNumber): include parser in value evaluation (#1567) * fix(module: input): fix & feat & docs & tests: Input general fixes (#1530) * docs(module:input): api correction & comments * fix(module:input): clear icon in sync with antD * fix(module:input): add parameter bordered * fix(module:textarea): add parameter ShowCounter * fix(module:input): Focus with behaviors * docs: add missing docs, rearrange order * fix(module:search): update to match new standard look doc(module:search): add API & demos * fix(module:inputgroup): override style to remove whitespace\ docs: same as react * fix(module:inputpassword): support custom icon docs: same as react * fix(module:input): add blur method docs: add blur method * fix(module:input): add readonly parameter * tests * fix * fix(module:input): sequence correction * Update components/core/Base/AntComponentBase.cs Co-authored-by: James Yeung <[email protected]> * review fixes * fix: clean-up * tests: fix missing mock * fix: focus * fix(module:input): bind clear button to _inputValue * tests: clear button show/hide * tests: package update Co-authored-by: James Yeung <[email protected]> * fix(module: drawer): OffsetX and offsetY do not work (#1435) (#1448) * fix(module: drawer): OffsetX and offsetY do not work (#1435) * docs: demo update * fix: Placement is switched to the relative direction, the animation appears * fix: the bug of closing animation missed * fix: incorrect animation * fix: different behaviors in WASM and Server side Co-authored-by: James Yeung <[email protected]> * docs: Added essential step in get started procedure (#1579) * Added essential step in get started procedure The article is missing the dependency registration. If these dependencies are not registered, the library couldn't be used (at least in my case). * Update getting-started.en-US.md Co-authored-by: James Yeung <[email protected]> * docs: document improvement (#1578) * fix the ordering of menu items * add ueditor link * fix icon document search style * fix affix width for side menu * add faq doc * feat(module: datepicker): Picker clear button event (#1586) * feat(module:datepicker): add OnClearClick eventcallback * docs(module:datepicker): format docs has same behavior as react docs * fix: adjust code to match net 3.1 * fix: eventcallback name fix * Update site/AntDesign.Docs/Demos/Components/DatePicker/doc/index.zh-CN.md Co-authored-by: James Yeung <[email protected]> * fix(module: dropdown): align with react (#1588) * fix(module:dropdownbutton): align with react version * doc(module:dropdownbutton): align with react docs * fix(module: table): fix can not close filter by confirm button (#1602) * fix(module: table): fix filter icon wrong highlight, fix filter behavior when there is no input value (#1592) * fix(module:table): fix filter icon wrong highlight * Update Column.razor * fix(module:table): fix filter for no input * fix(module: table): fix filter not applied (#1594) * fix(module: InputNumber): fix error when blur (#1612) * fix(affix): remove wrong event listeners (#1616) * fix(module: table): fix wrong compare operator, remove input components for unary filter operators (#1596) * fix(module:table): fix wrong compare operator * remove whitespace * fix(module:table): remove input component for 'is null' and 'is not null' table filter * Update Column.razor * fix(module:table): allow remove first filter * remove whitespace * Update Column.razor * Update Column.razor Co-authored-by: James Yeung <[email protected]> * fix(module: dropdown): dropdown button missing properties & docs fix for Dropdown & Button (#1609) * fix:fix(module:dropdownbutton): add regular button behaviors and properties * fix(module:button): add text type & docs * docs(module:dropdown): version correction * fix(module:overlay): re-add IsButton parameter * fix: add xml comment to public methods * fix(module:overlay): add xml documentation * fix(module:dropdown): chrome block button force * fix(module:button): remove Search parameter Co-authored-by: James Yeung <[email protected]> * fix(module: datepicker): in form behavior (#1617) * i18n: Add missing elements to Dutch locales (#1624) * chore(ci): fix coverage report uploading (#1614) * chore(ci): fix coverage report uploading * continue when fail to upload * docs: update modal and drawer docs (#1625) * docs: update modal docs * docs: modify DropdownInDrawer * docs: update demo for DrawerService and ModalService * fix(module: modal): Modal dialogs not showing anymore (#1635) * Fix issue #1634 - Modal dialogs not showing anymore * Removed unnecessary Search from ButtonProps as part of #1634 fix - Modal dialogs not showing anymore * fix(module: table): fix selection clear (#1632) * fix(module:table): fix selection issues * allow SetSeletion(null) when there is not a Selection column * allow change selection by setting RowDate.Selected * fix(module: checkbox): fix checkbox group in-form behavior (#1637) * fix(module: image): fix the style property position (#1642) * fix(module: tag): Issue solved & align with react antd & tests (#1631) * fix(module:tag): close does not trigger onclick add custom color handling add animation handling add status tags * docs(module:tag): align with react antd * tests(module:tag): add basic tests * fix: style fixes * fix: remove default animation; add custom animation demo * fix: remove ExtraCls and use Class from base * Update components/tag/Tag.razor * clear the open animate after tag opened * translate demo docs Co-authored-by: James Yeung <[email protected]> * changelog 0.8.2 (#1649) * add Visible back to Tag.razor.cs * Update SearchLoading.razor and idnex.en-US.md * Update index.zh-CN.md Co-authored-by: 笨木头 <[email protected]> Co-authored-by: James Yeung <[email protected]> Co-authored-by: Magehernan <[email protected]> Co-authored-by: Andrzej Bakun <[email protected]> Co-authored-by: zxyao <[email protected]> Co-authored-by: black-snake <[email protected]> Co-authored-by: Gregory Loones <[email protected]> Co-authored-by: Razvan Predescu <[email protected]>

* fix(module: drawer): OffsetX and offsetY do not work (#1435) * docs: demo update * fix: Placement is switched to the relative direction, the animation appears * fix: the bug of closing animation missed * fix: incorrect animation * fix: different behaviors in WASM and Server side Co-authored-by: James Yeung <[email protected]>

* test: DateHelperTests was in the wrong dir (#1529) * fix(module: radio): add defaultChecked and defaultValue (#1494) * fix(module: radio): add defaultChecked and defaultValue * add tests * add test for radio group * feat: Added locale es-ES (#1534) * fix(module: locale): add missing 'filterOptions' node to german locale file (#1562) * docs(module: table): update ‘fork official sample’ demo (#1544) Co-authored-by: James Yeung <[email protected]> * fix(module: npuNumber): include parser in value evaluation (#1567) * fix(module: input): fix & feat & docs & tests: Input general fixes (#1530) * docs(module:input): api correction & comments * fix(module:input): clear icon in sync with antD * fix(module:input): add parameter bordered * fix(module:textarea): add parameter ShowCounter * fix(module:input): Focus with behaviors * docs: add missing docs, rearrange order * fix(module:search): update to match new standard look doc(module:search): add API & demos * fix(module:inputgroup): override style to remove whitespace\ docs: same as react * fix(module:inputpassword): support custom icon docs: same as react * fix(module:input): add blur method docs: add blur method * fix(module:input): add readonly parameter * tests * fix * fix(module:input): sequence correction * Update components/core/Base/AntComponentBase.cs Co-authored-by: James Yeung <[email protected]> * review fixes * fix: clean-up * tests: fix missing mock * fix: focus * fix(module:input): bind clear button to _inputValue * tests: clear button show/hide * tests: package update Co-authored-by: James Yeung <[email protected]> * fix(module: drawer): OffsetX and offsetY do not work (#1435) (#1448) * fix(module: drawer): OffsetX and offsetY do not work (#1435) * docs: demo update * fix: Placement is switched to the relative direction, the animation appears * fix: the bug of closing animation missed * fix: incorrect animation * fix: different behaviors in WASM and Server side Co-authored-by: James Yeung <[email protected]> * docs: Added essential step in get started procedure (#1579) * Added essential step in get started procedure The article is missing the dependency registration. If these dependencies are not registered, the library couldn't be used (at least in my case). * Update getting-started.en-US.md Co-authored-by: James Yeung <[email protected]> * docs: document improvement (#1578) * fix the ordering of menu items * add ueditor link * fix icon document search style * fix affix width for side menu * add faq doc * feat(module: datepicker): Picker clear button event (#1586) * feat(module:datepicker): add OnClearClick eventcallback * docs(module:datepicker): format docs has same behavior as react docs * fix: adjust code to match net 3.1 * fix: eventcallback name fix * Update site/AntDesign.Docs/Demos/Components/DatePicker/doc/index.zh-CN.md Co-authored-by: James Yeung <[email protected]> * fix(module: dropdown): align with react (#1588) * fix(module:dropdownbutton): align with react version * doc(module:dropdownbutton): align with react docs * fix(module: table): fix can not close filter by confirm button (#1602) * fix(module: table): fix filter icon wrong highlight, fix filter behavior when there is no input value (#1592) * fix(module:table): fix filter icon wrong highlight * Update Column.razor * fix(module:table): fix filter for no input * fix(module: table): fix filter not applied (#1594) * fix(module: InputNumber): fix error when blur (#1612) * fix(affix): remove wrong event listeners (#1616) * fix(module: table): fix wrong compare operator, remove input components for unary filter operators (#1596) * fix(module:table): fix wrong compare operator * remove whitespace * fix(module:table): remove input component for 'is null' and 'is not null' table filter * Update Column.razor * fix(module:table): allow remove first filter * remove whitespace * Update Column.razor * Update Column.razor Co-authored-by: James Yeung <[email protected]> * fix(module: dropdown): dropdown button missing properties & docs fix for Dropdown & Button (#1609) * fix:fix(module:dropdownbutton): add regular button behaviors and properties * fix(module:button): add text type & docs * docs(module:dropdown): version correction * fix(module:overlay): re-add IsButton parameter * fix: add xml comment to public methods * fix(module:overlay): add xml documentation * fix(module:dropdown): chrome block button force * fix(module:button): remove Search parameter Co-authored-by: James Yeung <[email protected]> * fix(module: datepicker): in form behavior (#1617) * i18n: Add missing elements to Dutch locales (#1624) * chore(ci): fix coverage report uploading (#1614) * chore(ci): fix coverage report uploading * continue when fail to upload * docs: update modal and drawer docs (#1625) * docs: update modal docs * docs: modify DropdownInDrawer * docs: update demo for DrawerService and ModalService * fix(module: modal): Modal dialogs not showing anymore (#1635) * Fix issue #1634 - Modal dialogs not showing anymore * Removed unnecessary Search from ButtonProps as part of #1634 fix - Modal dialogs not showing anymore * fix(module: table): fix selection clear (#1632) * fix(module:table): fix selection issues * allow SetSeletion(null) when there is not a Selection column * allow change selection by setting RowDate.Selected * fix(module: checkbox): fix checkbox group in-form behavior (#1637) * fix(module: image): fix the style property position (#1642) * fix(module: tag): Issue solved & align with react antd & tests (#1631) * fix(module:tag): close does not trigger onclick add custom color handling add animation handling add status tags * docs(module:tag): align with react antd * tests(module:tag): add basic tests * fix: style fixes * fix: remove default animation; add custom animation demo * fix: remove ExtraCls and use Class from base * Update components/tag/Tag.razor * clear the open animate after tag opened * translate demo docs Co-authored-by: James Yeung <[email protected]> * changelog 0.8.2 (#1649) * add Visible back to Tag.razor.cs * Update SearchLoading.razor and idnex.en-US.md * Update index.zh-CN.md Co-authored-by: 笨木头 <[email protected]> Co-authored-by: James Yeung <[email protected]> Co-authored-by: Magehernan <[email protected]> Co-authored-by: Andrzej Bakun <[email protected]> Co-authored-by: zxyao <[email protected]> Co-authored-by: black-snake <[email protected]> Co-authored-by: Gregory Loones <[email protected]> Co-authored-by: Razvan Predescu <[email protected]>

pr-triage bot added the PR: unreviewed label May 1, 2021

zxyao145 requested a review from ElderJames May 1, 2021 13:11

anddrzejb reviewed May 1, 2021

View reviewed changes

zxyao145 force-pushed the issue/1435 branch from 565b09c to 3cfe865 Compare May 12, 2021 05:20

zxyao145 force-pushed the issue/1435 branch from 3cfe865 to 0e155ad Compare May 14, 2021 06:22

anddrzejb previously approved these changes May 14, 2021

View reviewed changes

pr-triage bot added PR: partially-approved and removed PR: unreviewed labels May 14, 2021

ElderJames previously approved these changes May 14, 2021

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: partially-approved labels May 14, 2021

ElderJames added PR: partially-approved and removed PR: reviewed-approved labels May 14, 2021

zxyao145 dismissed stale reviews from ElderJames and anddrzejb via dd4c316 May 15, 2021 03:11

pr-triage bot added PR: unreviewed and removed PR: partially-approved labels May 15, 2021

zxyao145 added 5 commits May 26, 2021 21:29

fix(module: drawer): OffsetX and offsetY do not work (ant-design-blaz…

756b073

…or#1435)

docs: demo update

2b72dc0

fix: Placement is switched to the relative direction, the animation a…

004e4e0

…ppears

fix: the bug of closing animation missed

950969d

fix: incorrect animation

41f7bc6

zxyao145 force-pushed the issue/1435 branch from 930e2a0 to 41f7bc6 Compare May 26, 2021 13:31

fix: different behaviors in WASM and Server side

6254acd

ElderJames approved these changes May 28, 2021

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels May 28, 2021

Merge branch 'master' into issue/1435

925daad

pr-triage bot added PR: unreviewed and removed PR: reviewed-approved labels May 28, 2021

ElderJames enabled auto-merge (squash) May 28, 2021 05:43

ElderJames linked an issue May 28, 2021 that may be closed by this pull request

Drawer OffsetX not working #1435

Closed

ElderJames merged commit 75d9a87 into ant-design-blazor:master May 28, 2021

pr-triage bot added PR: merged and removed PR: unreviewed labels May 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(module: drawer): OffsetX and offsetY do not work (#1435) #1448

fix(module: drawer): OffsetX and offsetY do not work (#1435) #1448

zxyao145 commented May 1, 2021

github-actions bot commented May 1, 2021 •

edited

Loading

codecov-commenter commented May 1, 2021 •

edited

Loading

anddrzejb May 1, 2021

zxyao145 May 2, 2021

anddrzejb May 2, 2021

zxyao145 May 2, 2021

anddrzejb commented May 11, 2021

zxyao145 commented May 12, 2021

anddrzejb commented May 14, 2021

ElderJames commented May 14, 2021

zxyao145 commented May 15, 2021

ElderJames commented May 17, 2021

		@@ -1,8 +1,10 @@
		import { getDom } from '../interop';

		// @ts-ignore

fix(module: drawer): OffsetX and offsetY do not work (#1435) #1448

fix(module: drawer): OffsetX and offsetY do not work (#1435) #1448

Conversation

zxyao145 commented May 1, 2021

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

github-actions bot commented May 1, 2021 • edited Loading

codecov-commenter commented May 1, 2021 • edited Loading

Codecov Report

anddrzejb May 1, 2021

Choose a reason for hiding this comment

zxyao145 May 2, 2021

Choose a reason for hiding this comment

anddrzejb May 2, 2021

Choose a reason for hiding this comment

zxyao145 May 2, 2021

Choose a reason for hiding this comment

anddrzejb commented May 11, 2021

zxyao145 commented May 12, 2021

anddrzejb commented May 14, 2021

ElderJames commented May 14, 2021

zxyao145 commented May 15, 2021

ElderJames commented May 17, 2021

github-actions bot commented May 1, 2021 •

edited

Loading

codecov-commenter commented May 1, 2021 •

edited

Loading