fix(module:inputpassword): focus fix #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1146 +/- ##
=========================================
- Coverage 6.55% 6.55% -0.01%
=========================================
Files 436 436
Lines 24414 24427 +13
=========================================
Hits 1600 1600
- Misses 22814 22827 +13
Continue to review full report at Codecov.
|
|
@ElderJames Hold with merge. Same problem is with |
|
The commit 333673c solved the problem of focus for password, search and input with AllowClear or Prefix or Suffix (all of them were not focusing). It is a unified solution, meant for all components that use |
Closed
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
* fix(module:inputpassword): focus fix * fix(module:search): focus fix * fix(module:input): (and descendants) focuse fix
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
* fix(module:inputpassword): focus fix * fix(module:search): focus fix * fix(module:input): (and descendants) focuse fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
#952
💡 Background and solution
For password
<input>tag is wrapped in a spanThat span (base on react ant design) should get an extra class on focus
ant-input-affix-wrapper-focus. My fix is including this class when input password receives focus.☑️ Self Check before Merge