Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tbrom pyvista 24r2 #142

Merged
merged 14 commits into from
Jan 11, 2024
Merged

Feat/tbrom pyvista 24r2 #142

merged 14 commits into from
Jan 11, 2024

Conversation

chrpetre
Copy link
Collaborator

@chrpetre chrpetre commented Jan 3, 2024

follow up of abandoned PR #126 :

This PR introduces new capabilities regarding 3D field visualization

  • it refactors the way field data based on point cloud are handled : the field data are stored as part of a PyVista DataSet object (accessible through new API TwinModel.get_tbrom_output_field), and automatically updated whenever the model is initialized or evaluated
  • associated unit testing
  • update of existing example to show usage of PyVista object for field visualization

It also refactors some part of the code

  • numpy dependency moved to >=1.17, pyvisa >=0.38.6 introduced as dependency
  • Examples in the documentation are split under multiple subsections (Twin models, TBROM evaluations,...)

@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Package and maintenance related dependencies Related with project dependencies enhancement New features or code improvements labels Jan 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (49a8feb) 87.61% compared to head (454f018) 87.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
- Coverage   87.61%   87.56%   -0.05%     
==========================================
  Files          11       11              
  Lines        2398     2461      +63     
==========================================
+ Hits         2101     2155      +54     
- Misses        297      306       +9     

@chrpetre chrpetre requested review from lboucin and EDCarman January 4, 2024 11:10
@chrpetre chrpetre mentioned this pull request Jan 4, 2024
Copy link
Collaborator

@lboucin lboucin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There are great simplifications in this one thanks to the usage of the pyvista.PolyData object. I've just made minor comments on naming conventions and possible new concept we should add if we want to expose the pyvista object as a public one from a tbrom.

src/ansys/pytwin/evaluate/tbrom.py Outdated Show resolved Hide resolved
src/ansys/pytwin/evaluate/tbrom.py Outdated Show resolved Hide resolved
src/ansys/pytwin/evaluate/tbrom.py Show resolved Hide resolved
src/ansys/pytwin/evaluate/tbrom.py Show resolved Hide resolved
src/ansys/pytwin/evaluate/tbrom.py Show resolved Hide resolved
src/ansys/pytwin/evaluate/tbrom.py Show resolved Hide resolved
src/ansys/pytwin/evaluate/tbrom.py Show resolved Hide resolved
src/ansys/pytwin/evaluate/twin_model.py Outdated Show resolved Hide resolved
tests/evaluate/test_tbrom.py Show resolved Hide resolved
tests/evaluate/test_tbrom.py Show resolved Hide resolved
@chrpetre
Copy link
Collaborator Author

chrpetre commented Jan 9, 2024

thanks @lboucin for the detailed review, all your comments are normally addressed

@chrpetre chrpetre merged commit 0633050 into main Jan 11, 2024
23 checks passed
@chrpetre chrpetre deleted the feat/tbrom_pyvista_24r2 branch January 11, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants