-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/tbrom pyvista 24r2 #142
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 87.61% 87.56% -0.05%
==========================================
Files 11 11
Lines 2398 2461 +63
==========================================
+ Hits 2101 2155 +54
- Misses 297 306 +9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! There are great simplifications in this one thanks to the usage of the pyvista.PolyData object. I've just made minor comments on naming conventions and possible new concept we should add if we want to expose the pyvista object as a public one from a tbrom.
for more information, see https://pre-commit.ci
thanks @lboucin for the detailed review, all your comments are normally addressed |
remove the mode field storage from pyvista object
for more information, see https://pre-commit.ci
follow up of abandoned PR #126 :
This PR introduces new capabilities regarding 3D field visualization
It also refactors some part of the code