Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/context manager #67

Merged
merged 18 commits into from
Nov 2, 2022
Merged

Feat/context manager #67

merged 18 commits into from
Nov 2, 2022

Conversation

PanekOndrej
Copy link
Collaborator

@PanekOndrej PanekOndrej commented Nov 1, 2022 •
edited
Loading

  • documentation of context manager

PanekOndrej and others added 12 commits October 13, 2022 17:47
@PanekOndrej PanekOndrej linked an issue Nov 1, 2022 that may be closed by this pull request
Implement context manager and implement dispose() #57
Closed
6 tasks
@PanekOndrej PanekOndrej linked an issue Nov 1, 2022 that may be closed by this pull request
When using KeyboardInterrupt (Ctrl+C) to end osl, the optiSLang process is killed, but the __refresh_listener_registration is still active causing OslCommunicationErrors #46
Closed
@rfahlberg
Copy link
Collaborator

@PanekOndrej please resolve conflicts.

@rfahlberg rfahlberg merged commit f7a6588 into main Nov 2, 2022
@rfahlberg rfahlberg deleted the feat/context-manager branch November 2, 2022 09:29
rfahlberg pushed a commit that referenced this pull request Nov 2, 2022
@PanekOndrej @rfahlberg
Feat/context manager (#67)
a7ee078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfahlberg rfahlberg rfahlberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@PanekOndrej @rfahlberg