Fix/tcp osl server processing started #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OWN" for general_listener. We don't want to receive (and osl to issue) all notifications.
…TION_STARTED notification. This ensures that start (wait_for_started=True) actually waits for the project status transitioning to PROCESSING.
|
@rfahlberg Thanks for review and bug fixes. Is that so |
|
Perfect, this notification will be available in 2023R1 so we can discard previous pull request? |
This was
linked to
issues
Oct 19, 2022
Yes. |
PanekOndrej
approved these changes
Oct 19, 2022
… args need to be appended to subprocess "args" separately.
rfahlberg
added a commit
that referenced
this pull request
Nov 2, 2022
Co-authored-by: PanekOndrej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PanekOndrej This is based on your original branch "fix/tcp_osl_server" and changes usage of EXECUTION_STARTED notification to PROCESSING_STARTED notification which has been added to optiSLang this week.