Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maint/typing #284

Merged
merged 54 commits into from
May 13, 2024
Merged

Maint/typing #284

merged 54 commits into from
May 13, 2024

Conversation

widerschein
Copy link
Member

@widerschein widerschein commented May 8, 2024 •
edited
Loading

Reduce typing error count from 409 to 145. Common issues are

  • Wrong return type annotations, especially for optional properties
  • Optionals that are left unchecked
  • Missing annotations for locals
  • Use of __class__ attribute in static methods, which is not wholly wrong but questionable practice
  • Mixing up of class objects and class instance objects in annotations

Also fix runtime behavior in some places and add a mypy config file.

widerschein added 30 commits May 7, 2024 06:50
@widerschein
Resolve typing issues
6f62b67
@widerschein
Add missing abstract property setter
1710d1f
@widerschein
Don't mark property as optional
959a390
@widerschein
Always expect a project UID
f2781a0 
Fail right away in case the UID cannot be retrieved instead of
swallowing the exception and leaving the application in a weird state.
@widerschein
Add missing method in base class
e85269c
@widerschein
Fix rich comparison implementation
9b114a7
@widerschein
Handle cases of no project loaded
0e8daf7
@widerschein
Add mypy config file
f402da3
@widerschein
Address typing issues for optiSLang server class properties
4caee90
@widerschein
Use plain string literals
c1dae8b
@widerschein
Add type annotations
8448663
@widerschein
Reduce use of __class__ attribute in static methods
4221457
@widerschein
Reduce use of __class__
c054bcd
@widerschein
Fix missing return statement
c1e7966
@widerschein
Make Optional explicit
c759b5b
@widerschein
Simplify test cases
f699a80
@widerschein
Call static methods with instance
0423eec
@widerschein
Call static methods with instance
0b610d6
@widerschein
Fix class type annotations
cfc3c9f
@widerschein
Rename local
fe757d7
@widerschein
Ignore type
21bbea1
@widerschein
Use classmethod for factories
7f5d765
@widerschein
Make helper function generic for Enum subclasses
4499e98
@widerschein
Fix return type
fbd9ea0
@widerschein
Avoid some awkward syntax
d3f08f4
@widerschein
Add missing decorator
c868723
@widerschein
Fix signature
1cc1d86
@widerschein
Fix narrowing for callable type
abab2de
@widerschein
Don't use is_connected internally
4c5c4a0
@widerschein
Fix signature
a982382
@widerschein widerschein marked this pull request as ready for review May 12, 2024 12:09
@widerschein widerschein enabled auto-merge (squash) May 12, 2024 12:13
@widerschein widerschein disabled auto-merge May 13, 2024 07:57
@widerschein widerschein merged commit 16b0a07 into main May 13, 2024
32 checks passed
@widerschein widerschein deleted the maint/typing branch May 13, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PanekOndrej PanekOndrej PanekOndrej approved these changes

@rfahlberg rfahlberg Awaiting requested review from rfahlberg

@benjaminbendig benjaminbendig Awaiting requested review from benjaminbendig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@widerschein @PanekOndrej