Added convenience functionality for result file handling. #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rfahlberg
commented
Aug 21, 2023
•
rfahlberg
commented
- Extended ParametricSystem wrapper class by interface / convenience functionality to:
- Obtain path to result OMDB file (resemble functionality of OWS "/omdb" endpoints)
- Generate and store a CSV/Json file containing result designs
- Extended Node wrapper class by interface / convenience functionality to:
- Obtain information about node result files
- Extended Project wrapper class by
- Obtain information about project result files
3 tasks
PanekOndrej
reviewed
Aug 21, 2023
There was a problem hiding this comment.
Unit tests are not yet done, I'm currently working on another project (and wanted to proceed after confirmation of #155 (comment)). Do you need me to finish this ASAP or can it wait? I estimate that I need about 0.5 day to finish this.
|
@PanekOndrej, if possible, please finish ASAP. If not, we can add the unit tests in a separate PR. |
benjaminbendig
previously approved these changes
Aug 22, 2023
15 minutes please, just in case you want to merge |
PanekOndrej
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.