Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to ***inq functions #799

Merged
merged 30 commits into from
Jan 4, 2022
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 3, 2022

Close #798 by implementing the ``***inq``` functions

Check list:

  • Mapdl implementations (console, corba and grpc).
  • Mapdl refined grpc implementation
  • Documentation. (Pretty much scrapped copied from the MAPDL internals. Therefore, we should probably make sure the info is releasable.
  • Test units. They are going to be very small, since they are undocumented and we are not ensuring fully support. I'm just going to make sure the commands run and get an output with valid format.

@germa89 germa89 self-assigned this Jan 3, 2022
@germa89 germa89 marked this pull request as draft January 3, 2022 16:54
@germa89 germa89 marked this pull request as draft January 3, 2022 16:54
@akaszynski
Copy link
Collaborator

Test units. They are going to be very small, since they are undocumented and we are not ensuring fully support. I'm just going to make sure the commands run and get an output with valid format.

Agreed.

@germa89
Copy link
Collaborator Author

germa89 commented Jan 3, 2022

As mentioned before, there are quite a lot of info in the docstrings which I'm not sure if we want to share. Some guidance is appreciated.

Nevertheless, if we are intending PyMAPDL becomes somehow the new way of interact with MAPDL, I see that this documentation is going to be the reference, not only for checking PyMAPDL commands but also MAPDL commands (given the similar syntax and the lack of official public documentation).
Hence I believe we should be ambitious regarding the scope of this documentation and give as much info as possible.

@germa89 germa89 marked this pull request as ready for review January 3, 2022 18:28
Copy link
Collaborator Author

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applying code review.

ansys/mapdl/core/mapdl_grpc.py Outdated Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating my suggestions. Looks good to me!

@akaszynski akaszynski merged commit 482c960 into main Jan 4, 2022
@akaszynski akaszynski deleted the feat/inq-functions-support branch January 4, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

***inq functions support
2 participants