Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exit getting frozen if routine is not finished #3617

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Dec 12, 2024

Description

This is very strange issue which I will have to check better.

Also we were killing the server twice on Windows, which made the second call frozen.

Issue linked

Close #3616

Checklist

@germa89 germa89 requested a review from a team as a code owner December 12, 2024 12:20
@germa89 germa89 self-assigned this Dec 12, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.99%. Comparing base (0ef6161) to head (454b075).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3617   +/-   ##
=======================================
  Coverage   86.99%   86.99%           
=======================================
  Files         187      187           
  Lines       14628    14630    +2     
=======================================
+ Hits        12725    12727    +2     
  Misses       1903     1903           

@germa89
Copy link
Collaborator Author

germa89 commented Dec 12, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 1473bdd into main Dec 12, 2024
49 of 52 checks passed
@germa89 germa89 deleted the fix/exit-method-getting-frozen-when-not-ending-routine branch December 12, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAPDL 25R1 does not exit properly on Windows
2 participants