Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoiding long names in test arguments #3583

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 27, 2024

Description

This is just for cosmetic purposes

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner November 27, 2024 09:26
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 27, 2024 09:26
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 27, 2024
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Nov 27, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.98%. Comparing base (1473bdd) to head (ed108db).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3583      +/-   ##
==========================================
+ Coverage   86.97%   86.98%   +0.01%     
==========================================
  Files         187      187              
  Lines       14630    14649      +19     
==========================================
+ Hits        12725    12743      +18     
- Misses       1905     1906       +1     

@germa89
Copy link
Collaborator Author

germa89 commented Dec 13, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 43ed236 into main Dec 13, 2024
50 of 51 checks passed
@germa89 germa89 deleted the fix/new-lines-in-test-arguments branch December 13, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants