Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/adding missing argument #3293

Merged
merged 2 commits into from
Aug 20, 2024
Merged

feat/adding missing argument #3293

merged 2 commits into from
Aug 20, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 18, 2024

Description

As the title.

Issue linked

Close #3277

Checklist

@germa89 germa89 requested a review from a team as a code owner July 18, 2024 07:10
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team July 18, 2024 07:10
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jul 18, 2024
@github-actions github-actions bot added the new feature Request or proposal for a new feature label Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.15%. Comparing base (81d8afd) to head (7678eba).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3293      +/-   ##
==========================================
+ Coverage   87.14%   87.15%   +0.01%     
==========================================
  Files          55       55              
  Lines        9768     9768              
==========================================
+ Hits         8512     8513       +1     
+ Misses       1256     1255       -1     

@germa89 germa89 enabled auto-merge (squash) July 18, 2024 09:09
@germa89
Copy link
Collaborator Author

germa89 commented Aug 20, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 99eedcd into main Aug 20, 2024
65 of 66 checks passed
@germa89 germa89 deleted the feat/adding-tolerance-to-hemiopt branch August 20, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HEMIOPT is missing the 'tolerance' on the function definition.
2 participants