Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: checking documentation style in Examples directory too #3191

Merged
merged 9 commits into from
Jun 24, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 20, 2024

Description

Checking documentation style in Examples directory too. As per: ansys/actions#509

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner June 20, 2024 12:00
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for pyansys-ci-bot June 20, 2024 12:00
@germa89 germa89 added the CI/CD Related with CICD, Github Actions, etc label Jun 20, 2024
@germa89 germa89 requested a review from jorgepiloto June 20, 2024 12:00
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 changed the title ci: checking documentation style in Examples directory too. As per: https://github.com/ansys/actions/pull/509 ci: checking documentation style in Examples directory too. Jun 20, 2024
@germa89 germa89 changed the title ci: checking documentation style in Examples directory too. ci: checking documentation style in Examples directory too Jun 20, 2024
@germa89 germa89 changed the title ci: checking documentation style in Examples directory too ci: checking documentation style in Examples directory too Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.21%. Comparing base (7c1eb1e) to head (7cba4cd).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3191      +/-   ##
==========================================
- Coverage   86.63%   84.21%   -2.43%     
==========================================
  Files          52       53       +1     
  Lines        9550     9625      +75     
==========================================
- Hits         8274     8106     -168     
- Misses       1276     1519     +243     

@germa89
Copy link
Collaborator Author

germa89 commented Jun 20, 2024

Please notice the change in the styles path:

# Location of our `styles`
StylesPath = "../doc/styles"

examples/.vale.ini Outdated Show resolved Hide resolved
@germa89 germa89 self-assigned this Jun 24, 2024
@germa89 germa89 requested a review from clatapie June 24, 2024 10:09
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 enabled auto-merge (squash) June 24, 2024 10:51
@germa89 germa89 merged commit 64285bf into main Jun 24, 2024
38 checks passed
@germa89 germa89 deleted the ci/checking-also-the-style-in-examples-directory branch June 24, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants