Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pool to connect to remote MAPDL instances #2862

Merged
merged 27 commits into from
Mar 11, 2024
Merged

Allow pool to connect to remote MAPDL instances #2862

merged 27 commits into from
Mar 11, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 8, 2024

The idea is that the pool module should work with remote instances too.

We should handle the starting of those remote instances manually.

from ansys.mapdl.core.pool import LocalMapdlPool

pool = MapdlPool(2, start_instance=False, port=[50092, 50093])
print(pool)

The class will be renamed of course.

The idea is to prepare this module for HPC computations.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Mar 8, 2024
@germa89 germa89 requested a review from a team as a code owner March 9, 2024 13:59
@germa89 germa89 requested a review from PipKat March 11, 2024 11:48
@germa89
Copy link
Collaborator Author

germa89 commented Mar 11, 2024

@pyansys-ci-bot LGTM.

pyansys-ci-bot
pyansys-ci-bot approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 0769951 into main Mar 11, 2024
57 checks passed
@germa89 germa89 deleted the feat/allow-pool-to-connect-to-remote-instances branch March 11, 2024 12:09
@germa89
Copy link
Collaborator Author

germa89 commented Mar 11, 2024 •
edited by unfurl-links bot
Loading

Tested globally here: https://github.com/ansys/pymapdl/actions/runs/8232264386/job/22509332692

GitHub
Pythonic interface to MAPDL. Contribute to ansys/pymapdl development by creating an account on GitHub.

@germa89 germa89 mentioned this pull request Mar 11, 2024
Open
@germa89 germa89 mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie clatapie is a code owner automatically assigned from ansys/pymapdl-maintainers

@PipKat PipKat Awaiting requested review from PipKat

Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@germa89 @PipKat @pyansys-ci-bot