Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamping landing page #2727

Merged
merged 43 commits into from
Feb 5, 2024
Merged

Revamping landing page #2727

merged 43 commits into from
Feb 5, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 31, 2024

As the title.

  • changed colors (lighter dark, darker light)
  • using a grid for info
  • changed the footer
  • changed grid glow to golden.
  • added tag thispagetitle for changing website name.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jan 31, 2024
@germa89 germa89 requested a review from clatapie January 31, 2024 12:34
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fee354) 85.00% compared to head (74f885a) 82.97%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2727      +/-   ##
==========================================
- Coverage   85.00%   82.97%   -2.03%     
==========================================
  Files          47       47              
  Lines        9322     9323       +1     
==========================================
- Hits         7924     7736     -188     
- Misses       1398     1587     +189     

@germa89

This comment was marked as outdated.

@germa89
Copy link
Collaborator Author

germa89 commented Feb 2, 2024

Credits to @clatapie for the logo idea.

@germa89
Copy link
Collaborator Author

germa89 commented Feb 2, 2024

Final output:

Dark mode

image

Light mode

image

@germa89 germa89 enabled auto-merge (squash) February 2, 2024 23:47
@germa89
Copy link
Collaborator Author

germa89 commented Feb 5, 2024

Pinging @clatapie for review

Pinging @Revathyvenugopal162 and @jorgepiloto for awareness since they are the ansys-sphinx-theme maintainers. I believe we could port some changes from this PR to the default theme.

@germa89
Copy link
Collaborator Author

germa89 commented Feb 5, 2024

This time I got internal approval... soooooo....

@pyansys-ci-bot LGTM

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 3b8d3db into main Feb 5, 2024
29 checks passed
@germa89 germa89 deleted the doc/clearing-landing-page branch February 5, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants