Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing secrets from CICD: Part I Docs and local #2583

Merged
merged 23 commits into from
Dec 22, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Dec 22, 2023

First iteration

@germa89 germa89 requested a review from a team as a code owner December 22, 2023 15:59
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance labels Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c95e7da) 83.97% compared to head (b7fb001) 82.10%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2583      +/-   ##
==========================================
- Coverage   83.97%   82.10%   -1.88%     
==========================================
  Files          46       46              
  Lines        9067     9090      +23     
==========================================
- Hits         7614     7463     -151     
- Misses       1453     1627     +174     

@germa89 germa89 self-assigned this Dec 22, 2023
@germa89 germa89 changed the title Removing secrets from CICD: Docs and local Removing secrets from CICD: Part I Docs and local Dec 22, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Dec 22, 2023

It seems that the same entrypoint as the centos images (-smp -np 2)

docker run \
    --name mapdl \
    --restart always \
    --health-cmd="ps aux | grep \"[/]ansys_inc/.*ansys\.e.*grpc\" -q && echo 0 || echo 1" \
    --health-interval=0.5s \
    --health-retries=4 \
    --health-timeout=0.5s \
    --health-start-period=10s \
    -e ANSYSLMD_LICENSE_FILE=1055@$LICENSE_SERVER \
    -e ANSYS_LOCK="OFF" \
    -p $PYMAPDL_PORT:50052 \
    -p $PYMAPDL_DB_PORT:50055 \
    --shm-size=1gb \
    -e I_MPI_SHM_LMT=shm \
    -e P_SCHEMA=/ansys_inc/ansys/ac4/schema \
    --oom-kill-disable \
    --memory=6656MB  \
    --memory-swap=16896MB \
    $MAPDL_IMAGE \
    -$DISTRIBUTED_MODE -np 2 > log.txt &

Gives the following error:

Status: Downloaded newer image for ghcr.io/ansys/mapdl:v24.1-ubuntu-student
ghcr.io/ansys/mapdl:v24.1-ubuntu-student
Abort(15) on node 0 (rank 0 in comm 0): application called MPI_Abort(MPI_COMM_WORLD, 15) - process 0
Error: Process completed with exit code 1.

However it seems to work if I remove most of the stuff:

docker run \
    --name mapdl \
    --restart always \
    -e ANSYS_LOCK="OFF" \
    -p $PYMAPDL_PORT:50052 \
    -p $PYMAPDL_DB_PORT:50055 \
    --shm-size=2gb \
    -e P_SCHEMA=/ansys_inc/v241/ansys/ac4/schema \
    $MAPDL_IMAGE > log.txt &
# grep -q 'Server listening on' <(timeout 60 tail -f log.txt)

@germa89
Copy link
Collaborator Author

germa89 commented Dec 22, 2023

I had to disable the following tests:

test_license_type_keyword

Because the licenses we were pinging are not the student license. I should look for this license name It seems it is ansys.

test_license_type_keyword_names

Because it was taking too long (timeout)

I have also seen:

Maximum licensed number of demo users already reached.

Probably because several instances running.... I wonder if this is going to be an issue in the pool module

@germa89 germa89 requested a review from koubaa December 22, 2023 18:53
@germa89
Copy link
Collaborator Author

germa89 commented Dec 22, 2023

@pyansys-ci-bot LGTM

@germa89 germa89 enabled auto-merge (squash) December 22, 2023 19:11
@germa89
Copy link
Collaborator Author

germa89 commented Dec 22, 2023

@pyansys-ci-bot LGTM

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit d08bdd4 into main Dec 22, 2023
29 checks passed
@germa89 germa89 deleted the feat/removing-secrets branch December 22, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants