Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documenting non-interactive #2496

Merged
merged 27 commits into from
Nov 21, 2023
Merged

Documenting non-interactive #2496

merged 27 commits into from
Nov 21, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 8, 2023 •
edited
Loading

As the title.

Also not allowing mapdl.parameters retrieval in non_interactive.

Close #2376

@germa89 germa89 requested a review from clatapie November 8, 2023 12:56
@germa89 germa89 self-assigned this Nov 8, 2023
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 requested a review from PipKat November 8, 2023 12:59
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023 •
edited
Loading

Codecov Report

Merging #2496 (27ceeec) into main (949b8d8) will increase coverage by 0.06%.
Report is 15 commits behind head on main.
The diff coverage is 93.33%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2496      +/-   ##
==========================================
+ Coverage   83.83%   83.89%   +0.06%     
==========================================
  Files          44       44              
  Lines        8685     8755      +70     
==========================================
+ Hits         7281     7345      +64     
- Misses       1404     1410       +6

@germa89 germa89 requested review from koubaa and mikerife November 8, 2023 16:23
@germa89
Copy link
Collaborator Author

germa89 commented Nov 8, 2023

Asking technical review to @mikerife @mcMunich @clatapie and @koubaa

Documentation review to @PipKat and @clatapie

PipKat
PipKat approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits suggested.

@germa89
Copy link
Collaborator Author

germa89 commented Nov 21, 2023

Minor edits suggested.

Thank you a lot @PipKat !

@germa89 germa89 merged commit df48beb into main Nov 21, 2023
28 checks passed
@germa89 germa89 deleted the doc/documenting-non_interactive branch November 21, 2023 16:34
mikerife
mikerife reviewed Nov 21, 2023
View reviewed changes
Copy link

@mikerife mikerife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To late for this but looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerife mikerife mikerife left review comments

@PipKat PipKat PipKat approved these changes

@clatapie clatapie clatapie approved these changes

@koubaa koubaa Awaiting requested review from koubaa

Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[doc] Adding a section about non_interactive
4 participants
@germa89 @clatapie @PipKat @mikerife