Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing skip regression check cli argument #2487

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Removing skip regression check cli argument #2487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6831bc2
Removing skip regression check cli argument
germa89 Nov 7, 2023
52f7ccc
Removing pytest-pyvista argument
germa89 Nov 8, 2023
341409f
Merge branch 'main' into fix/removing-skip-regression-test-option
germa89 Nov 8, 2023
4960a02
Merge branch 'main' into fix/removing-skip-regression-test-option
germa89 Nov 8, 2023
8531a5b
Merge branch 'main' into fix/removing-skip-regression-test-option
germa89 Nov 8, 2023
4063a76
Merge branch 'main' into fix/removing-skip-regression-test-option
germa89 Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,6 @@ jobs:
export ANSYSLMD_LICENSE_FILE=1055@${{ secrets.LICENSE_SERVER }}
pytest -k "not test_dpf" \
${{ env.PYTEST_ARGUMENTS }} \
--skip-regression-check \
--cov-report=xml:ubuntu-v22.2.0-local-minimal.xml

- uses: codecov/codecov-action@v3
Expand Down
12 changes: 0 additions & 12 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,12 +245,6 @@ def pytest_addoption(parser):
default=False,
help="run only GUI tests",
)
parser.addoption(
"--skip-regression-check",
action="store_true",
default=False,
help="Avoid checking the image regression check in all tests",
)


def pytest_collection_modifyitems(config, items):
Expand Down Expand Up @@ -302,13 +296,7 @@ def pytest_collection_modifyitems(config, items):

@pytest.fixture(autouse=True)
def wrapped_verify_image_cache(verify_image_cache, pytestconfig):
# Checking if we want to avoid the check using pytest cli.
skip_regression_check = pytestconfig.option.skip_regression_check
if skip_regression_check:
verify_image_cache.skip = True

# Configuration
# default check
verify_image_cache.error_value = 500.0
verify_image_cache.warning_value = 200.0

Expand Down
Loading