Fixing plot indexing #2476
Merged
Fixing plot indexing #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding `mapdl` (lowercase) to accepts. Fixing other warnings.
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov Report
@@ Coverage Diff @@
## main #2476 +/- ##
==========================================
+ Coverage 83.76% 83.81% +0.04%
==========================================
Files 44 44
Lines 8660 8660
==========================================
+ Hits 7254 7258 +4
+ Misses 1406 1402 -4 |
|
Needed, so ... LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working in #2471 I found out that
test_plot_incomplete_nodal_selectionwas not passing, not sure what did I change in that PR (I check I promise).Hence I'm bringing the fix I did for that in a separate PR to highlight its importance.
I have also extensively documented the approach so the future developers (me) know what I did.