Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding step for importing library and check plotting support. #2399

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 9, 2023

I think importing the library should be part of the smok tests.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Oct 9, 2023
@germa89 germa89 added the CI/CD Related with CICD, Github Actions, etc label Oct 9, 2023
@germa89 germa89 requested a review from clatapie October 9, 2023 17:32
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #2399 (06ffafb) into main (b84acb7) will increase coverage by 5.95%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2399      +/-   ##
==========================================
+ Coverage   81.93%   87.88%   +5.95%     
==========================================
  Files          44       44              
  Lines        8453     8453              
==========================================
+ Hits         6926     7429     +503     
+ Misses       1527     1024     -503     

@germa89
Copy link
Collaborator Author

germa89 commented Oct 10, 2023

LGTM

@germa89 germa89 enabled auto-merge (squash) October 10, 2023 08:37
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit b7f1753 into main Oct 10, 2023
24 checks passed
@germa89 germa89 deleted the ci/import-package-in-smoke-tests branch October 10, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants