-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding files to pull request #2359
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov Report
@@ Coverage Diff @@
## main #2359 +/- ##
==========================================
- Coverage 87.48% 87.42% -0.06%
==========================================
Files 44 44
Lines 8455 8455
==========================================
- Hits 7397 7392 -5
- Misses 1058 1063 +5 |
Testing commit |
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 😄 |
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
== No changes/comment should happen after this == |
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
Soo... because we reset the cache every time of all the images, all the images are attached. We need pyvista/pytest-pyvista#82 to be merged in order to overwrite only the ones that fails. |
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
Ready to review. In this commit b0ee04d I changed the background for plots. This brokes the tests in the ubuntu local test, which basically get the new image cache and upload them as a commit. Later in this 69b2c9a, I have reset the image cache to the one in main, so nothing should get triggered. Pinging @RobPasMue @jorgepiloto @AlejandroFernandezLuces @clatapie for feedback and/or approval. |
Make CICD to add files to pull request.