Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding plottly support to gallery examples #2346

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 19, 2023

@germa89 germa89 self-assigned this Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.93%. Comparing base (6012cd8) to head (dbb3516).
Report is 59 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2346      +/-   ##
==========================================
+ Coverage   86.77%   86.93%   +0.15%     
==========================================
  Files          55      187     +132     
  Lines        9989    14619    +4630     
==========================================
+ Hits         8668    12709    +4041     
- Misses       1321     1910     +589     
---- 🚨 Try these New Features:

@germa89
Copy link
Collaborator Author

germa89 commented Sep 19, 2023

It renders a white empty space:

image

@germa89
Copy link
Collaborator Author

germa89 commented Sep 20, 2023

Currently it is needing something on ansys-sphinx-theme. Nothing we can do about this at the moment. Converting in draft.

@germa89 germa89 marked this pull request as draft September 20, 2023 13:50
@germa89 germa89 added the DO NOT MERGE Not ready to be merged yet label Sep 20, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Sep 21, 2023

If depends on ansys-sphinx-theme, we need first for this to resolve: ansys/ansys-sphinx-theme#301

@germa89
Copy link
Collaborator Author

germa89 commented Sep 21, 2023

Closing for the moment.

@germa89 germa89 closed this Sep 21, 2023
@germa89 germa89 deleted the doc/adding-plotly-support-to-docs branch September 21, 2023 11:41
@germa89 germa89 restored the doc/adding-plotly-support-to-docs branch October 15, 2024 09:00
@germa89 germa89 reopened this Oct 15, 2024
@github-actions github-actions bot added examples Publishing PyMAPDL examples documentation Documentation related (improving, adding, etc) labels Oct 15, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Oct 15, 2024

Still it does not work... I get a white space instead of the plot.

image

I did build the documentation using the CICD, download the html artifact and open it with the browser. I believe, I do not require to have a live http server.... But I might be wrong

@jorgepiloto @Revathyvenugopal162

@jorgepiloto
Copy link
Member

jorgepiloto commented Oct 17, 2024

@germa89
Copy link
Collaborator Author

germa89 commented Nov 25, 2024

Could you try this config, @germa89? https://github.com/plotly/plotly-sphinx-gallery/blob/9a82c6de451843cd86368a07770adc661f2918fe/docs/conf.py#L187-L198

GitHub**plotly-sphinx-gallery/docs/conf.py at 9a82c6de451843cd86368a07770adc661f2918fe · plotly/plotly-sphinx-gallery**Demo of gallery of examples using plotly for visualization and sphinx-gallery - plotly/plotly-sphinx-gallery

Testing this in dbb3516

GitHub
Demo of gallery of examples using plotly for visualization and sphinx-gallery - plotly/plotly-sphinx-gallery

@germa89
Copy link
Collaborator Author

germa89 commented Nov 26, 2024

@jorgepiloto it is still broken... Maybe I am doing something wrong? Can you check the example and/or configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Not ready to be merged yet documentation Documentation related (improving, adding, etc) examples Publishing PyMAPDL examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Plotly capabilities to gallery examples
3 participants