Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix geometry connection command tests on earlier MAPDL versions #2339

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Fix geometry connection command tests on earlier MAPDL versions #2339

merged 5 commits into from
Sep 18, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 18, 2023

As the title.

@germa89 germa89 self-assigned this Sep 18, 2023
@germa89 germa89 added BUG CI/CD Related with CICD, Github Actions, etc labels Sep 18, 2023
@germa89 germa89 marked this pull request as ready for review September 18, 2023 08:19
@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited
Loading

Codecov Report

Merging #2339 (2cc27c9) into main (489b49b) will increase coverage by 5.96%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2339      +/-   ##
==========================================
+ Coverage   81.68%   87.65%   +5.96%     
==========================================
  Files          45       45              
  Lines        8513     8513              
==========================================
+ Hits         6954     7462     +508     
+ Misses       1559     1051     -508

@germa89
Copy link
Collaborator Author

germa89 commented Sep 18, 2023

#PeopleAreOnHolidays #MinorWorks LGTM.

@germa89 germa89 enabled auto-merge (squash) September 18, 2023 12:37
@germa89 germa89 merged commit 0022f4e into main Sep 18, 2023
47 checks passed
pyansys-ci-bot
pyansys-ci-bot approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 deleted the fix/geometry-tests-on-earlier-versions branch September 18, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

Assignees

@germa89 germa89

Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germa89 @pyansys-ci-bot