Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing link in approver comment #2262

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Fixing link in approver comment #2262

merged 1 commit into from
Aug 18, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 18, 2023

As the title.

@germa89 germa89 added the CI/CD Related with CICD, Github Actions, etc label Aug 18, 2023
@germa89 germa89 requested a review from clatapie August 18, 2023 12:50
@germa89 germa89 self-assigned this Aug 18, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Aug 18, 2023

LGTM.

@germa89 germa89 enabled auto-merge (squash) August 18, 2023 12:50
pyansys-ci-bot
pyansys-ci-bot approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #2262 (b1bb6b2) into main (e3885fb) will decrease coverage by 1.25%.
Report is 94 commits behind head on main.
The diff coverage is 93.31%.

@@            Coverage Diff             @@
##             main    #2262      +/-   ##
==========================================
- Coverage   86.39%   85.15%   -1.25%     
==========================================
  Files          45       45              
  Lines        7977     8339     +362     
==========================================
+ Hits         6892     7101     +209     
- Misses       1085     1238     +153

@germa89 germa89 merged commit 6916e19 into main Aug 18, 2023
@germa89 germa89 deleted the fix/approver-link branch August 18, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie

Assignees

@germa89 germa89

Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germa89 @pyansys-ci-bot