-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating pyvista to 0.41 #2194
Updating pyvista to 0.41 #2194
Conversation
this update breaks:
tests/test_mapdl.py:10: in <module>
from ansys.mapdl.reader.rst import Result
/opt/hostedtoolcache/Python/3.9.17/x64/lib/python3.9/site-packages/ansys/mapdl/reader/rst.py:18: in <module>
from pyvista.themes import DefaultTheme
E ModuleNotFoundError: No module named 'pyvista.themes'
tests/test_dpf.py:4: in <module>
from ansys.dpf import core as dpf
/opt/hostedtoolcache/Python/3.9.17/x64/lib/python3.9/site-packages/ansys/dpf/core/__init__.py:101: in <module>
settings.set_default_pyvista_config()
/opt/hostedtoolcache/Python/3.9.17/x64/lib/python3.9/site-packages/ansys/dpf/core/settings.py:35: in set_default_pyvista_config
pv.rcParams["interactive"] = True
/opt/hostedtoolcache/Python/3.9.17/x64/lib/python3.9/site-packages/pyvista/__init__.py:95: in __getattr__
raise AttributeError(f"module 'pyvista' has no attribute '{name}'") from None
E AttributeError: module 'pyvista' has no attribute 'rcParams' I can fix PyMAPDL reader, but DPF is another story... @PProfizi So I'm going to fix first PyMAPDL-Reader. ansys/pymapdl-reader#287 |
Hi @germa89, this is already fixed on pydpf-core ;) ansys/pydpf-core#1045 |
In the meantime, #2198 |
Codecov Report
@@ Coverage Diff @@
## main #2194 +/- ##
==========================================
- Coverage 86.43% 81.88% -4.56%
==========================================
Files 45 45
Lines 7971 8296 +325
==========================================
- Hits 6890 6793 -97
- Misses 1081 1503 +422 |
…nsys/pymapdl into maint/update-pyvista-to-0.41
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Updating pyvista to 0.41 * Updating reader * Removing rcParams * Using pyvista 0.41.1 * Avoiding importing dpf. * adding missing import * Update tests/test_dpf.py * maint: updating `ansys-dpf-core` version * test: fixing `test_heal` * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * test: revert last commit --------- Co-authored-by: Camille <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Updating pyvista to 0.41 (#2194) * Updating pyvista to 0.41 * Updating reader * Removing rcParams * Using pyvista 0.41.1 * Avoiding importing dpf. * adding missing import * Update tests/test_dpf.py * maint: updating `ansys-dpf-core` version * test: fixing `test_heal` * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * test: revert last commit --------- Co-authored-by: Camille <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Including import into try clause. --------- Co-authored-by: Camille <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
As the title.