Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping Python 3.7 support #2117

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Dropping Python 3.7 support #2117

merged 2 commits into from
Jun 14, 2023

Conversation

clatapie
Copy link
Contributor

This would follow ansys/pyansys#228.

@clatapie clatapie requested review from germa89 and RobPasMue June 14, 2023 08:13
@clatapie clatapie marked this pull request as ready for review June 14, 2023 08:13
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Dependencies labels Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #2117 (333c812) into main (09d55a4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2117      +/-   ##
==========================================
+ Coverage   86.43%   86.45%   +0.01%     
==========================================
  Files          45       45              
  Lines        7971     7981      +10     
==========================================
+ Hits         6890     6900      +10     
  Misses       1081     1081              

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one comment.

@RobPasMue RobPasMue enabled auto-merge (squash) June 14, 2023 08:45
@RobPasMue RobPasMue merged commit 12fc720 into main Jun 14, 2023
@RobPasMue RobPasMue deleted the maint/drop_python_3.7 branch June 14, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants