Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multidependabot ci #2088

Merged
merged 5 commits into from
Jun 12, 2023
Merged

Fix multidependabot ci #2088

merged 5 commits into from
Jun 12, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented May 30, 2023

As the title.

@germa89 germa89 added BUG CI/CD Related with CICD, Github Actions, etc labels May 30, 2023
@germa89 germa89 requested a review from clatapie May 30, 2023 17:16
@germa89 germa89 self-assigned this May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #2088 (ae1d5a5) into main (09d55a4) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head ae1d5a5 differs from pull request most recent head 31b0736. Consider uploading reports for the commit 31b0736 to get more accurate results

@@            Coverage Diff             @@
##             main    #2088      +/-   ##
==========================================
+ Coverage   86.43%   86.48%   +0.04%     
==========================================
  Files          45       45              
  Lines        7971     7969       -2     
==========================================
+ Hits         6890     6892       +2     
+ Misses       1081     1077       -4     

@germa89
Copy link
Collaborator Author

germa89 commented May 31, 2023

It seems I was wrong. The problem is not the PAT. The action is broken. It seems it is trying to pull an inexistent image from the docker registry.

I have reported this in:
marcoroth/dependabot-bump-together-action#20

And propose a solution in:
marcoroth/dependabot-bump-together-action#21

Therefore, I'm going to change the scope of this PR to prepare for a possible update. I will keep the other changes because they are minimal.

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@germa89
Copy link
Collaborator Author

germa89 commented Jun 2, 2023

Because the action is not working, I dont know if the change in the PAT will fix it. Let's leave this PR open for the moment, and see.

@germa89
Copy link
Collaborator Author

germa89 commented Jun 5, 2023

We might need to use the action with its main branch:

steps:
      - uses: marcoroth/dependabot-bump-together-action@main
        with:
          dependencies: ansys-api-mapdl, vtk, ansys-corba, ansys-dpf-core, ansys-mapdl-reader, ansys-platform-instancemanagement, ansys-sphinx-theme, pyansys-tools-report, appdirs, autopep8, click, imageio-ffmpeg, imageio, importlib-metadata, jupyter_sphinx, jupyterlab, matplotlib, numpy, numpydoc, pandas, pexpect, plotly, protobuf, pyiges, pypandoc, pytest-cov, pytest-rerunfailures, pytest-sphinx, pytest, pythreejs, pyvista, scipy, setuptools, sphinx-autobuild, sphinx-autodoc-typehints, sphinx-copybutton, sphinx-gallery, sphinx-notfound-page, sphinxcontrib-websupport, sphinxemoji, tqdm, wheel
          package_managers: pip

@germa89 germa89 enabled auto-merge (squash) June 12, 2023 10:01
@germa89 germa89 merged commit d0e1cca into main Jun 12, 2023
@germa89 germa89 deleted the ci/multidependabot-fix branch June 12, 2023 10:27
@germa89 germa89 changed the title Fix mutidependabot ci Fix multidependabot ci Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants