Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pydata analytics option #1756

Merged
merged 13 commits into from
Feb 23, 2023
Merged

Using pydata analytics option #1756

merged 13 commits into from
Feb 23, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 4, 2023

Trying to avoid another dependency

@germa89 germa89 requested review from a team and clatapie and removed request for a team January 4, 2023 18:23
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Please add one of the following labels to add this contribution to the Release Notes 👇

@germa89
Copy link
Collaborator Author

germa89 commented Jan 4, 2023

This doesn't work until pydata-sphinx-theme is updated. This depends on this PR ansys/ansys-sphinx-theme#155

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #1756 (ea718ed) into main (a5e46bc) will increase coverage by 3.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1756      +/-   ##
==========================================
+ Coverage   82.53%   85.82%   +3.28%     
==========================================
  Files          44       44              
  Lines        7844     7844              
==========================================
+ Hits         6474     6732     +258     
+ Misses       1370     1112     -258     

pyproject.toml Outdated Show resolved Hide resolved
@germa89
Copy link
Collaborator Author

germa89 commented Feb 22, 2023

Closing for the moment. I will reopen when sphinx theme is compatible.

@germa89 germa89 closed this Feb 22, 2023
@germa89 germa89 reopened this Feb 23, 2023
@github-actions github-actions bot added the CI/CD Related with CICD, Github Actions, etc label Feb 23, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Feb 23, 2023

LGTM

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so 😬

@germa89 germa89 removed the request for review from clatapie February 23, 2023 05:42
@germa89 germa89 merged commit 54258bb into main Feb 23, 2023
@germa89 germa89 deleted the fix/analytics-using-pydata branch February 23, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants