-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CommandOutput improvements #1554
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lass Fix a bug that omitted the last number on the listing. Added unit tests
Adding unit test
Style checks fails because I actually want the raw MAPDL output which includes spaces at the end of several lines. I will force the merge when the other ticks are green. |
Codecov Report
@@ Coverage Diff @@
## main #1554 +/- ##
==========================================
+ Coverage 82.17% 82.21% +0.04%
==========================================
Files 43 43
Lines 6821 6843 +22
==========================================
+ Hits 5605 5626 +21
- Misses 1216 1217 +1 |
github-actions
bot
added
CI/CD
Related with CICD, Github Actions, etc
Maintenance
labels
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
magicwords
kwarg definition when instantiating CommandListingOutput classset,list
with the command output listingmapdl.post_processing.set
using the wrappedset,list
This is a perfect example of spaghetti issue... you start with something simple and fixing small things, and then you end up rewriting a lot of stuff.