Add quad tri support #268
Merged
Add quad tri support #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akaszynski - just removed Python 3.7 from the required stages, and added Python 3.11 We will plan on creating such an action. Thanks for proposing it! |
|
Thank you @RobPasMue and @akaszynski |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #260 by adding support for degenerate quadratic triangular elements.
MAPDL does not write out 0s at the end of lines, and quad elements with missing midside nodes will have fewer than 8 nodes, which resulted in point indices not being allocated, leading to reading out of bounds in rare cases.
These triangular elements were also misencoded as quads within VTK. This PR resolves both these issues.
Bonus
pre-commit@jorgepiloto and @RobPasMue, please consider enforcing code style for C files using ClangFormat. Works quite well, and you can even consider adopting a different standard (see Clang-Format Style Options).
@germa89, since we're dropping Python 3.7, please remove them from the required workflows.