Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding temperature dependent properties (arrays). #150

Merged
merged 4 commits into from
Aug 30, 2022
Merged

Adding temperature dependent properties (arrays). #150

merged 4 commits into from
Aug 30, 2022

Conversation

germa89
Copy link
Contributor

@germa89 germa89 commented Aug 23, 2022 •
edited
Loading

As the title.

Close #151

@germa89 germa89 self-assigned this Aug 23, 2022
@germa89 germa89 requested review from akaszynski and mikerife August 23, 2022 18:54
@akaszynski
Copy link
Collaborator

Let's add a test for this.

@akaszynski akaszynski mentioned this pull request Aug 23, 2022
Closed
2 tasks
akaszynski
akaszynski approved these changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good tests and thanks for the validation in #151.

@akaszynski akaszynski merged commit 3c54e59 into main Aug 30, 2022
@akaszynski akaszynski deleted the feat/adding-temperature-dependent-support branch August 30, 2022 16:21
@akaszynski
Copy link
Collaborator

@germa89, please make a minor release. This seems to be a needed feature.

@germa89
Copy link
Contributor Author

germa89 commented Aug 31, 2022

@germa89, please make a minor release. This seems to be a needed feature.

Done. https://github.com/pyansys/pymapdl-reader/releases/tag/v0.52.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

@mikerife mikerife Awaiting requested review from mikerife

Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

materials dictionary in pymadl reader result
2 participants
@germa89 @akaszynski