feat: Classes for event info #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
requested review from
seanpearsonuk,
prmukherj and
hpohekar
as code owners
mkundu1
commented
Nov 27, 2024
seanpearsonuk
approved these changes
Nov 27, 2024
prmukherj
approved these changes
Nov 27, 2024
mkundu1
force-pushed
the
feat/event-info-cls
branch
2 times, most recently
from
31a5cf0 to
e96220f
Compare
mkundu1
force-pushed
the
feat/event-info-cls
branch
from
e96220f to
9f1d29f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining explicit classes for various types of event info. These class instances will be passed to the event-streaming callback instead of the protobuf message instances that are currently passed.
TODO: Update user guide, PyConsole change
Covered by exisitng unittests.