Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hiding switch-to-meshing-mode command from tui and settings #3381

Merged
merged 3 commits into from
Oct 16, 2024
Merged

fix: Hiding switch-to-meshing-mode command from tui and settings #3381

merged 3 commits into from
Oct 16, 2024

Conversation

raph-luc
Copy link
Member

@raph-luc raph-luc commented Oct 10, 2024 •
edited
Loading

ADO Fluent PR 530389
GitHub fluids-webui PR 398

Changes

  • Hiding switch-to-meshing-mode command from solver.tui and solver.settings
  • Adding tests to make sure this command does not appear in either location as we will most likely never want it in those locations, in my understanding

@raph-luc raph-luc changed the title fix: Hiding switch-to-meshing-mode command from tui and solver.settings fix: Hiding switch-to-meshing-mode command from tui and settings Oct 10, 2024
@raph-luc raph-luc marked this pull request as ready for review October 10, 2024 16:53
@raph-luc raph-luc requested a review from prmukherj October 11, 2024 13:02
@raph-luc raph-luc merged commit 38e2682 into main Oct 16, 2024
24 of 25 checks passed
@raph-luc raph-luc deleted the rluciano/d1138584-api-switch-to-meshing branch October 16, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prmukherj prmukherj prmukherj approved these changes

@mkundu1 mkundu1 mkundu1 approved these changes

@seanpearsonuk seanpearsonuk Awaiting requested review from seanpearsonuk seanpearsonuk is a code owner

@hpohekar hpohekar Awaiting requested review from hpohekar hpohekar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raph-luc @mkundu1 @prmukherj