Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle file-list in datamodel for file-transfer service. #3343

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Oct 1, 2024

No description provided.

@mkundu1 mkundu1 linked an issue Oct 1, 2024 that may be closed by this pull request
@mkundu1
Copy link
Contributor Author

mkundu1 commented Oct 1, 2024

@hpohekar I've followed the logic for before/after_exeute from flobject.py. Can you please confirm the changes for various launch scenarios (PIM etc.)?

Also, there is an inconsistency between upload/download functions of LocalFileTransferStrategy and RemoteFileTransferStrategy. The remote one supports multiple filenames in the implementation, but the local one doesn't.

Copy link
Collaborator

@seanpearsonuk seanpearsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@hpohekar
Copy link
Collaborator

hpohekar commented Oct 2, 2024

@hpohekar I've followed the logic for before/after_exeute from flobject.py. Can you please confirm the changes for various launch scenarios (PIM etc.)?

Also, there is an inconsistency between upload/download functions of LocalFileTransferStrategy and RemoteFileTransferStrategy. The remote one supports multiple filenames in the implementation, but the local one doesn't.

@mkundu1 Yes, sure. I will look into it. Thank you.

@mkundu1 mkundu1 merged commit b0da2ea into main Oct 2, 2024
26 checks passed
@mkundu1 mkundu1 deleted the fix/file-list branch October 2, 2024 12:08
prmukherj added a commit that referenced this pull request Oct 10, 2024
* fix: add missing methods (#3323)

add missing methods

* fix: Handle file-list in datamodel for file-transfer service. (#3343)

* fix: dir() over ArgumentWrapper. (#3321)

* fix: dir() over ArgumentWrapper.

* Update test.

* Update dir() of arg.

* Fix fluent side bug.

* update test marker.

* Update src/ansys/fluent/core/workflow.py

* Update logic.

* remove docstring.

* fix: Add missing event_type argument to BaseSession._build_from_fluent_connection (#3349)

* fix: Update LocalFileTransferStrategy (#3353)

* fix: Update LocalFileTransferStrategy

* fix: Update PIMLauncher

* refactoring

* fix: Update arguments behaviour. (#3332)

* fix: Update arguments behaviour.

* Minor fix.

* Update behaviour.

* Fix 'update_dict' w.r.t. server.

* fix: se dir fn (#3367)

* filtered dir

* filtered dir

* change to function object approach

* filtered dir

* filtered dir

* change to function object approach

* rm temp code

---------

Co-authored-by: Mainak Kundu <[email protected]>

* fix: Remove unimplemented iteration started event (#3368)

* fix: meshng wf update (#3356)

* meshng wf update

* tests

* meshng wf update

* tests

* Clean up.

* meshng wf update

* tests

* Clean up.

---------

Co-authored-by: Prithwish Mukherjee <[email protected]>
Co-authored-by: Prithwish Mukherjee <[email protected]>

* build: Bump version to v0.26.1

* Remove docformatter from ci.

* Skip tests for patch.

---------

Co-authored-by: Sean Pearson <[email protected]>
Co-authored-by: Mainak Kundu <[email protected]>
Co-authored-by: Harshal Pohekar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placeholder issue to fix Fluent bug 1139518 in PyFluent
3 participants