Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Builtin settings classes for Solution section #3310

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Sep 20, 2024

The following changes are included in this PR:

  1. Support of the following APIs for named objects:
ReportFile(solver=solver, name="report-file-1")  # returns existing object
ReportFile(solver=solver, new_instance_name="report-file-1")  # creates new object with name=<new_instance_name>
ReportFile(solver=solver)  # Creates new object with automatic naming
  1. Cover settings classes for Solution section of Fluent's outline view.

Future changes:

  1. Ability to attach/re-attach session attribute with the class instance.
  2. Better exception type/message.
  3. Cover the remaining sections of Fluent's outline view.

@mkundu1 mkundu1 marked this pull request as ready for review September 23, 2024 14:57
Copy link
Collaborator

@seanpearsonuk seanpearsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mkundu1 mkundu1 merged commit 8f20c7f into main Sep 24, 2024
26 checks passed
@mkundu1 mkundu1 deleted the feat/builtin-more branch September 24, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants