Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wf speed #3210

Merged
merged 25 commits into from
Aug 23, 2024
Merged

feat: wf speed #3210

merged 25 commits into from
Aug 23, 2024

Conversation

seanpearsonuk
Copy link
Collaborator

@seanpearsonuk seanpearsonuk commented Aug 16, 2024 •
edited by prmukherj
Loading

  1. Speed up "getattr" by optimizing camel-case conversion.
  2. Add "mark_as_updated" to force update the tasks.
  3. Separate out Classic and Enhanced meshing workflow.
  4. Return "None" from workflow (both Classic and Enhanced workflow), like 'path', 'docstring', etc.

@seanpearsonuk seanpearsonuk changed the title feat:wf speed feat: wf speed Aug 16, 2024
This was linked to issues Aug 20, 2024
Separate out the ClassicMeshingWorkflow interface #3038
Closed
doc string issue #3083
Closed
Syntax to Mark as updated in watertight workflow #1081
Closed
@prmukherj prmukherj marked this pull request as ready for review August 22, 2024 08:29
@prmukherj prmukherj requested a review from mkundu1 as a code owner August 22, 2024 08:29
@prmukherj prmukherj requested a review from PipKat August 22, 2024 12:34
@prmukherj
Copy link
Collaborator

@PipKat, could you please provide your views.
Thank you.

@prmukherj prmukherj linked an issue Aug 22, 2024 that may be closed by this pull request
Check and update the classic meshing workflow documentation #3222
Closed
PipKat
PipKat reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits/suggestions, mostly related to asking that nouns be used after code entities for clarity.

@prmukherj prmukherj merged commit e2d89e3 into main Aug 23, 2024
26 checks passed
@prmukherj prmukherj deleted the feat/wf-speed branch August 23, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@prmukherj prmukherj prmukherj approved these changes

@mkundu1 mkundu1 mkundu1 approved these changes

@hpohekar hpohekar hpohekar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@seanpearsonuk @prmukherj @PipKat @mkundu1 @hpohekar