Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extend unsubscribing cb for load and create wfs. #2869

Merged
merged 10 commits into from
May 29, 2024
Merged

Conversation

prmukherj
Copy link
Collaborator

@prmukherj prmukherj commented May 25, 2024

  1. Restructuring and clean up of enhanced meshing workflow.
  2. Fix issues with '_refresh_task_accessors' in PyConsole.
  3. Fix issues with initializing and re-initializing workflows.
  4. Testing done both in PyFluent as well as PyConsole.

@prmukherj prmukherj marked this pull request as ready for review May 29, 2024 07:18
@prmukherj prmukherj linked an issue May 29, 2024 that may be closed by this pull request
@seanpearsonuk
Copy link
Collaborator

I need a little reminding about the initialize() and reinitialize() methods. I would like to make sure that we need both of them (or even one of them). Also, there is a test comment mentioning a random CI issue connected to reinitialize() which I believe should be out of date now.

@prmukherj
Copy link
Collaborator Author

prmukherj commented May 29, 2024

I need a little reminding about the initialize() and reinitialize() methods. I would like to make sure that we need both of them (or even one of them). Also, there is a test comment mentioning a random CI issue connected to reinitialize() which I believe should be out of date now.

As of now there is nothing called initialize. Reinitialize just resets the same workflow to it's original state. Unsubscribing the callback is required only for initialization which is done in the constructor.

@prmukherj prmukherj merged commit ca32fd5 into main May 29, 2024
26 of 28 checks passed
@prmukherj prmukherj deleted the fix/affected-cb-2 branch May 29, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meshing workflow properties refactoring
3 participants