Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache per session #2729

Merged
merged 2 commits into from
Apr 22, 2024
Merged

fix: cache per session #2729

merged 2 commits into from
Apr 22, 2024

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Apr 22, 2024

Each session should have its own datamodel cache.

Copy link
Member

@raph-luc raph-luc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing issue seems unrelated to this PR and the same one that you previously described here: #2709 (comment)

And was also happening on main now: https://github.com/ansys/pyfluent/actions/runs/8784096749/job/24101652082

@mkundu1
Copy link
Contributor Author

mkundu1 commented Apr 22, 2024

Testing issue seems unrelated to this PR and the same one that you previously described here: #2709 (comment)

And was also happening on main now: https://github.com/ansys/pyfluent/actions/runs/8784096749/job/24101652082

I have enabled the file permission change logging for that directory - will see what is going on

@prmukherj
Copy link
Collaborator

@mkundu1, the test in my PR is passing now as well. Thank you.
#2728

@mkundu1 mkundu1 merged commit 1394d48 into main Apr 22, 2024
26 checks passed
@mkundu1 mkundu1 deleted the fix/cache branch April 22, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make datamodel caching session specific.
4 participants