-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: launcher code refactoring #2702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpohekar
requested review from
mkundu1,
seanpearsonuk,
ajain-work,
dnwillia-work,
prmukherj,
h-krishnan and
raph-luc
as code owners
April 17, 2024 08:40
hpohekar
commented
Apr 17, 2024
PipKat
reviewed
Apr 17, 2024
PipKat
reviewed
Apr 17, 2024
PipKat
reviewed
Apr 17, 2024
PipKat
reviewed
Apr 17, 2024
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
…/pyfluent into fix/launch_fluent_refactor
PipKat
reviewed
Apr 18, 2024
Co-authored-by: Kathy Pippert <[email protected]>
PipKat
reviewed
Apr 19, 2024
PipKat
reviewed
Apr 19, 2024
This reverts commit 6728f63.
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
prmukherj
approved these changes
Apr 22, 2024
seanpearsonuk
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2693
_get_graphics_driver
,_get_ui_mode
and_validate_gpu
.show_gui
to Standalone constructor signature.