Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Meshing Workflow test. #2654

Merged
merged 6 commits into from
Apr 9, 2024
+10 −13
Merged

refactor: Meshing Workflow test. #2654

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
361a36f
Refactor Meshing Workflow test.
prmukherj Apr 4, 2024
e350ef1
Update tests/test_new_meshing_workflow.py
prmukherj Apr 5, 2024
f79c5b3
Update tests/test_new_meshing_workflow.py
prmukherj Apr 5, 2024
ca66487
Merge branch 'main' into maint/refactor_meshing_workflow_tests
prmukherj Apr 8, 2024
cc88493
Update error check.
prmukherj Apr 9, 2024
7bc7613
Merge branch 'main' into maint/refactor_meshing_workflow_tests
prmukherj Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions tests/test_meshing_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,19 +419,6 @@ def test_old_workflow_structure(new_mesh_session):
)


@pytest.mark.fluent_version(">=23.2")
def test_new_workflow_structure(new_mesh_session):
meshing = new_mesh_session
watertight = meshing.watertight()
assert watertight.import_geometry.arguments()
with pytest.raises(AttributeError) as msg:
watertight.TaskObject["Import Geometry"]
assert (
msg.value.args[0]
== "'WatertightMeshingWorkflow' object has no attribute 'TaskObject'"
)


@pytest.mark.nightly
@pytest.mark.codegen_required
@pytest.mark.fluent_version(">=24.2")
Expand Down
15 changes: 14 additions & 1 deletion tests/test_new_meshing_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,7 +1054,20 @@ def downstream_names(task):
]


@pytest.mark.skip("Randomly failing in CI")
@pytest.mark.codegen_required
@pytest.mark.fluent_version(">=23.2")
def test_new_workflow_structure(new_mesh_session):
meshing = new_mesh_session
watertight = meshing.watertight()
assert watertight.import_geometry.arguments()
with pytest.raises(AttributeError) as msg:
watertight.TaskObject["Import Geometry"]
assert (
msg.value.args[0]
== "'WatertightMeshingWorkflow' object has no attribute 'TaskObject'"
prmukherj marked this conversation as resolved.
Show resolved Hide resolved
prmukherj marked this conversation as resolved.
Show resolved Hide resolved
prmukherj marked this conversation as resolved.
Show resolved Hide resolved
)

prmukherj marked this conversation as resolved.
Show resolved Hide resolved

prmukherj marked this conversation as resolved.
Show resolved Hide resolved
@pytest.mark.codegen_required
@pytest.mark.fluent_version(">=23.2")
def test_attrs_in_watertight_meshing_workflow(new_mesh_session):
Expand Down
Loading